Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsetting extensions from Yaml does not seem to work #10511

Closed
micschk opened this issue Sep 23, 2022 · 2 comments · Fixed by #10516
Closed

Unsetting extensions from Yaml does not seem to work #10511

micschk opened this issue Sep 23, 2022 · 2 comments · Fixed by #10516
Labels
affects/v4 affects/v5 complexity/medium impact/medium type/bug

Comments

@micschk
Copy link
Contributor

micschk commented Sep 23, 2022 •
edited by GuySartorelli
Loading

The below Yaml config produces an error: "Uncaught InvalidArgumentException: SilverStripe\Assets\File references nonexistent in 'extensions'".

SilverStripe\Assets\File:
  extensions:
    comments: SilverStripe\Comments\Extensions\CommentsExtension

This would allow you to disable that extension with only this code

SilverStripe\Assets\File:
  extensions:
    comments: null

The above code example was originally posted by @tractorcow in silverstripe/silverstripe-cms#2146 (comment)

PRs
@micschk micschk mentioned this issue Sep 23, 2022
Closed
@GuySartorelli GuySartorelli mentioned this issue Sep 26, 2022
Merged
@GuySartorelli GuySartorelli linked a pull request Sep 26, 2022 that will close this issue
FIX Allow removing named extensions in yaml config #10516
Merged
@GuySartorelli
Copy link
Member

Fixed with #10516

@micschk
Copy link
Contributor Author

micschk commented Sep 27, 2022

Great, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 affects/v5 complexity/medium impact/medium type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX Allow removing named extensions in yaml config creative-commoners/silverstripe-framework
2 participants
@micschk @GuySartorelli