Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Add MariaDB support #73

Merged
merged 1 commit into from
Nov 6, 2023
Merged

MNT Add MariaDB support #73

merged 1 commit into from
Nov 6, 2023

Conversation

sabina-talipova
Copy link
Contributor

Description

  • Add new constant DB_MARIADB;
  • Updated tests
  • Add DB_MYSQL_57 only for --prefer-lowest

Note:

I'm not sure should we replace all MySQL versions with MariaDB.

Parent issue

This was referenced Nov 6, 2023
Closed
Closed
GuySartorelli
GuySartorelli approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 94dcb7e into silverstripe:1 Nov 6, 2023
4 checks passed
@GuySartorelli GuySartorelli deleted the pulls/1/mariadb-integration-new branch November 6, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabina-talipova @GuySartorelli