Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Add MariaDB support #71

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova commented Nov 2, 2023

Description

  • Add new constant DB_MARIADB;
  • Updated tests
  • Add DB_MYSQL_57 only for --prefer-lowest

Note:

I'm not sure should we replace all MySQL versions with MariaDB.

Parent issue

@sabina-talipova sabina-talipova force-pushed the pulls/1.9/mariadb-integration branch 2 times, most recently from 00c734c to cb17c32 Compare November 2, 2023 03:18
@sabina-talipova sabina-talipova force-pushed the pulls/1.9/mariadb-integration branch from cb17c32 to 785c70a Compare November 2, 2023 03:21
@sabina-talipova sabina-talipova marked this pull request as ready for review November 2, 2023 03:24
@GuySartorelli
Copy link
Member

Do you have an example of this working in a fork somewhere, so I can validate what jobs will be created? Ideally one for CMS 4 and one for CMS 5 since those have different builds.

@sabina-talipova
Copy link
Contributor Author

Updated. New CI builds were run for CMS 4 and CMS 5

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please target 1 since this should be on a new minor release.

@sabina-talipova
Copy link
Contributor Author

Close. Open #73

@sabina-talipova sabina-talipova deleted the pulls/1.9/mariadb-integration branch November 6, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants