SF-3077 Add UI for mixed training sources

[RaymondLuong3]

This PR adds the ability to mix in training data from multiple sources. See the balsamiq for the original design.

No training books selected

Training books selected

---

This change is 

[Nateowami]

Observations:

• Bulk selecting NT or OT in the top panel doesn't cause the relevant books to update in the bottom panel

[codecov]

Codecov Report

Attention: Patch coverage is 97.91667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.90%. Comparing base (1897259) to head (7274455).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
...neration-steps/draft-generation-steps.component.ts	97.22%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2875      +/-   ##
==========================================
+ Coverage   80.84%   80.90%   +0.05%     
==========================================
  Files         533      533              
  Lines       31122    31193      +71     
  Branches     5061     5060       -1     
==========================================
+ Hits        25161    25236      +75     
- Misses       5198     5208      +10     
+ Partials      763      749      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Nateowami]

Here are some issues I'm seeing:

[josephmyers]

We'll also want to add an optional title parameter to the book selection component, which contains the bulk select checkboxes. Then place the project name on the same line as the checkboxes.

Reviewable status: 0 of 14 files reviewed, all discussions resolved

[Nateowami]

@RaymondLuong3 I should note that when selecting books in bulk, it seems that the first time yous select them it selects correctly, but then upon unselecting and re-selecting it doesn't.

[RaymondLuong3]

Thanks for finding that. I figured out the main issue was that arrays were being passed around by reference rather than by values. I've cleaned it up and now it works. I've also addressed the extra training books notice and the project label for the multi-book-select component.

Reviewable status: 0 of 16 files reviewed, all discussions resolved

[pmachapman]

I really like the new interface! Just a couple of minor nits.

...and thank you for fixing my frontend/realtimeserver mistakes on SF-2900 :-S

Reviewed 6 of 14 files at r3, 7 of 16 files at r4, 10 of 10 files at r5, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @RaymondLuong3)

---

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.spec.ts line 162 at r5 (raw file):

        mockAlternateTrainingSourceProjectDoc
      );
      when(mockFeatureFlagService.allowFastTraining).thenReturn(createTestFeatureFlag(false));

NIT: Should this be removed as it occurs 4 lines below?

Code quote:

when(mockFeatureFlagService.allowFastTraining).thenReturn(createTestFeatureFlag(false));

---

src/RealtimeServer/scriptureforge/services/sf-project-migrations.ts line 419 at r5 (raw file):

    }

    await submitMigrationOp(SFProjectMigration21.VERSION, doc, ops);

NIT: This should be:

await submitMigrationOp(SFProjectMigration22.VERSION, doc, ops);

Code quote:

await submitMigrationOp(SFProjectMigration21.VERSION, doc, ops);

---

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.ts line 414 at r5 (raw file):

    if (previousTrainingRange === '' && trainingScriptureRange != null) {
      previousTrainingRange =
        this.activatedProject.projectDoc?.data?.translateConfig.draftConfig.lastSelectedTrainingScriptureRange ?? '';

NIT: Should this just be previousTrainingRange = trainingScriptureRange, or am I misunderstanding the code?

Code quote:

      previousTrainingRange =
        this.activatedProject.projectDoc?.data?.translateConfig.draftConfig.lastSelectedTrainingScriptureRange ?? '';

[RaymondLuong3]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @RaymondLuong3)

---

src/RealtimeServer/scriptureforge/services/sf-project-migrations.ts line 419 at r5 (raw file):

Previously, pmachapman (Peter Chapman) wrote…

NIT: This should be:

await submitMigrationOp(SFProjectMigration22.VERSION, doc, ops);

Good catch!

---

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.ts line 414 at r5 (raw file):

Previously, pmachapman (Peter Chapman) wrote…

NIT: Should this just be previousTrainingRange = trainingScriptureRange, or am I misunderstanding the code?

Nice. Thanks

---

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.spec.ts line 162 at r5 (raw file):

Previously, pmachapman (Peter Chapman) wrote…

NIT: Should this be removed as it occurs 4 lines below?

Done.

[pmachapman]

Reviewed 3 of 3 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @RaymondLuong3)

[pmachapman]

Reviewed 5 of 5 files at r7, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @RaymondLuong3)