Code review fixes

sillsdev · Dec 17, 2024 · 6ebab5e · 6ebab5e
1 parent 73d9960
commit 6ebab5e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/src/RealtimeServer/scriptureforge/services/sf-project-migrations.ts b/src/RealtimeServer/scriptureforge/services/sf-project-migrations.ts
@@ -416,7 +416,7 @@ class SFProjectMigration22 extends DocMigration {
       }
     }
 
-    await submitMigrationOp(SFProjectMigration21.VERSION, doc, ops);
+    await submitMigrationOp(SFProjectMigration22.VERSION, doc, ops);
   }
 }
 

diff --git a/...ranslate/draft-generation/draft-generation-steps/draft-generation-steps.component.spec.ts b/...ranslate/draft-generation/draft-generation-steps/draft-generation-steps.component.spec.ts
@@ -159,7 +159,6 @@ describe('DraftGenerationStepsComponent', () => {
       when(mockProjectService.getProfile('alternateTrainingProject')).thenResolve(
         mockAlternateTrainingSourceProjectDoc
       );
-      when(mockFeatureFlagService.allowFastTraining).thenReturn(createTestFeatureFlag(false));
       when(mockTrainingDataService.queryTrainingDataAsync(anything())).thenResolve(instance(mockTrainingDataQuery));
       when(mockTrainingDataQuery.docs).thenReturn([]);
       when(mockFeatureFlagService.allowFastTraining).thenReturn(createTestFeatureFlag(false));

diff --git a/...app/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.ts b/...app/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.ts
@@ -407,11 +407,10 @@ export class DraftGenerationStepsComponent extends SubscriptionDisposable implem
       this.activatedProject.projectDoc?.data?.translateConfig.draftConfig.lastSelectedTrainingScriptureRanges?.find(
         r => r.projectId === trainingSourceId
       )?.scriptureRange ?? '';
-    const trainingScriptureRange =
+    const trainingScriptureRange: string | undefined =
       this.activatedProject.projectDoc?.data?.translateConfig.draftConfig.lastSelectedTrainingScriptureRange;
     if (previousTrainingRange === '' && trainingScriptureRange != null) {
-      previousTrainingRange =
-        this.activatedProject.projectDoc?.data?.translateConfig.draftConfig.lastSelectedTrainingScriptureRange ?? '';
+      previousTrainingRange = trainingScriptureRange;
     }
     const previousBooks: Set<number> = new Set<number>(booksFromScriptureRange(previousTrainingRange));
-Original file line number
+Diff line change
@@ Expand Up / @@ -416,7 +416,7 @@ class SFProjectMigration22 extends DocMigration { @@
           }
         }
-        await submitMigrationOp(SFProjectMigration21.VERSION, doc, ops);
+        await submitMigrationOp(SFProjectMigration22.VERSION, doc, ops);
       }
     }
@@ Expand Down @@