Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tutorial] Export 1: Update times; Add Spanish CC #3450

Merged
merged 7 commits into from
Dec 12, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Nov 15, 2024

This change is Reviewable

@imnasnainaec imnasnainaec added the documentation Improvements or additions to documentation label Nov 15, 2024
@imnasnainaec imnasnainaec self-assigned this Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.65%. Comparing base (0ea1184) to head (cc1ca13).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3450   +/-   ##
=======================================
  Coverage   74.65%   74.65%           
=======================================
  Files         285      285           
  Lines       10999    10999           
  Branches     1338     1338           
=======================================
  Hits         8211     8211           
  Misses       2404     2404           
  Partials      384      384           
Flag Coverage Δ
backend 83.62% <ø> (ø)
frontend 66.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)


docs/tutorial_subtitles/export_1_flex_to_combine/export_1_flex_to_combine.spa.txt line 8 at r1 (raw file):

Aparece otro diálogo para que seleccione dónde se guardarán los archivos exportados.
Necesitarás crear una nueva carpeta para los archivos.
Voy a Desktop y hago clic en el botón “Make New Folder” para crear una carpeta Naskapi.

Could have spanish here? Evaluate

Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @jasonleenaylor)


docs/tutorial_subtitles/export_1_flex_to_combine/export_1_flex_to_combine.spa.txt line 8 at r1 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

Could have spanish here? Evaluate

Added.

@imnasnainaec imnasnainaec marked this pull request as draft December 9, 2024 19:54
@imnasnainaec imnasnainaec marked this pull request as ready for review December 12, 2024 20:41
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit f938b11 into master Dec 12, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the tutorial/flex-combine branch December 12, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants