Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
TransformContextConfig
struct which is passed to each transform at the point where theTransformConfig
is converted to aTransformBuilder
. i.e. during shotover initializationThis enables a whole bunch of potential optimizations where we pass in some extra information about the context the transform is in. i.e. the chain its in and what other transforms are in its chain.
A potential future optimization would be detecting if the next transform is going to discard any responses passed to it.
This would allow for a nice optimization to the Filter transform where we skip error generation if its in a Tee subchain configured to discard responses.
However right now,
TransformContextConfig
just contains:Additionally theCodecBuilder::websocket_subprotocol
is turned into aCodecBuilder::protocol
so that we can obtain the protocol to insert into theTransformContextConfig
.