Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodecBuilder::protocol #1491

Merged
merged 1 commit into from
Feb 21, 2024
Merged

CodecBuilder::protocol #1491

merged 1 commit into from
Feb 21, 2024

Conversation

rukai
Copy link
Member

@rukai rukai commented Feb 21, 2024

Pulled out of #1490 but adjusted a bit to use MessageType instead of ProtocolType which will be deleted.

This better abstracts our ability to retrieve the protocol type from a codec builder.
Previously we could only get a string used for websockets.
But now we get an enum that we can convert into the websockets string or use for other purposes.

Copy link

0 benchmark regressed. 2 benchmark improved. Please check the benchmark workflow logs for full details: https://github.com/shotover/shotover-proxy/actions/runs/7984440539

Found 4 outliers among 100 measurements (4.00%)
  1 (1.00%) high mild
  3 (3.00%) high severe
kafka_codec/decode_request_list_offsets_drop
                        time:   [250.10 ns 251.12 ns 252.40 ns]
                        change: [-28.407% -25.479% -22.328%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
  5 (5.00%) low severe
  1 (1.00%) low mild
kafka_codec/encode_request_list_offsets
                        time:   [552.61 ns 562.03 ns 571.35 ns]
                        change: [-28.323% -24.961% -21.331%] (p = 0.00 < 0.05)
                        Performance has improved.

@rukai rukai force-pushed the codec_protocol_type branch 2 times, most recently from 4b23b57 to 53f417f Compare February 21, 2024 06:01
@rukai rukai force-pushed the codec_protocol_type branch from 53f417f to 5f14aa6 Compare February 21, 2024 06:06
@rukai rukai requested a review from conorbros February 21, 2024 06:37
@conorbros conorbros merged commit b662a5f into shotover:main Feb 21, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants