Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaSinkSingle SASL authentication tests #1478

Merged
merged 6 commits into from
Feb 22, 2024
Merged

Conversation

conorbros
Copy link
Member

No description provided.

@conorbros conorbros changed the title kafka sasl tests KafkaSinkSingle SASL authentication tests Feb 19, 2024
@conorbros conorbros requested a review from rukai February 19, 2024 23:42
@conorbros conorbros force-pushed the kafka-sasl branch 2 times, most recently from 243abcd to 4b98fb1 Compare February 20, 2024 00:18
@conorbros conorbros marked this pull request as ready for review February 20, 2024 02:12
@shotover shotover deleted a comment from github-actions bot Feb 20, 2024
Copy link

0 benchmark regressed. 2 benchmark improved. Please check the benchmark workflow logs for full details: https://github.com/shotover/shotover-proxy/actions/runs/7997379924

Found 2 outliers among 100 measurements (2.00%)
  1 (1.00%) low mild
  1 (1.00%) high mild
cassandra_codec/decode_system.local_query_v5_no_compression
                        time:   [5.6398 µs 5.6632 µs 5.6922 µs]
                        change: [-24.685% -23.902% -23.095%] (p = 0.00 < 0.05)
                        Performance has improved.
--
                        Change within noise threshold.
Found 4 outliers among 100 measurements (4.00%)
  4 (4.00%) high mild
cassandra_codec/decode_system.local_query_v5_lz4_compression
                        time:   [5.6294 µs 5.6424 µs 5.6565 µs]
                        change: [-23.380% -22.474% -21.476%] (p = 0.00 < 0.05)
                        Performance has improved.

Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@rukai rukai enabled auto-merge (squash) February 22, 2024 10:58
Copy link

2 benchmark regressed. 0 benchmark improved. Please check the benchmark workflow logs for full details: https://github.com/shotover/shotover-proxy/actions/runs/8003374982

                        Change within noise threshold.
Found 9 outliers among 100 measurements (9.00%)
  5 (5.00%) high mild
  4 (4.00%) high severe
transform/nullsink      time:   [945.21 ns 952.88 ns 959.71 ns]
                        change: [+26.893% +28.201% +29.722%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) low mild
transform/redis_filter  time:   [2.5402 µs 2.5741 µs 2.6060 µs]
                        change: [+28.622% +33.527% +40.939%] (p = 0.00 < 0.05)
                        Performance has regressed.

@rukai rukai merged commit 9f7fca4 into shotover:main Feb 22, 2024
40 checks passed
@conorbros conorbros deleted the kafka-sasl branch May 23, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants