Skip to content

Commit

Permalink
review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
conorbros committed Feb 21, 2024
1 parent 867e28d commit 559d7ee
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 220 deletions.
8 changes: 4 additions & 4 deletions shotover-proxy/config/config.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# configure the first `debug` to set the log level for dependencies
# configure `shotover=debug` to set the log level for shotover itself
# set `shotover::connection_span=debug` to `shotover::connection_span=debug` to attach connection info to most log events, this is disabled by default due to a minor performance hit.
main_log_level: "debug, shotover=debug, shotover::connection_span=debug"
# configure the first `info` to set the log level for dependencies
# configure `shotover=info` to set the log level for shotover itself
# set `shotover::connection_span=info` to `shotover::connection_span=debug` to attach connection info to most log events, this is disabled by default due to a minor performance hit.
main_log_level: "info, shotover=info, shotover::connection_span=info"
observability_interface: "0.0.0.0:9001"
7 changes: 5 additions & 2 deletions shotover-proxy/tests/kafka_int_tests/test_cases.rs
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,10 @@ pub async fn basic_sasl(address: &str) {
// internal driver debug logs are emitted to tokio tracing, assuming the appropriate filter is used by the tracing subscriber
.set("debug", "all");
admin(client.clone()).await;
produce_consume(client.clone()).await;
produce_consume_acks0(client.clone()).await;
for i in 0..2 {
produce_consume(client.clone(), "partitions1", i).await;
produce_consume(client.clone(), "partitions3", i).await;
produce_consume_acks0(client.clone()).await;
}
admin_cleanup(client.clone()).await;
}

This file was deleted.

Binary file not shown.
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: '2'

services:
kafka:
image: 'bitnami/kafka:latest'
image: 'bitnami/kafka:3.6.1-debian-11-r24'
ports:
- '9092:9092'
- '9093:9093'
Expand Down
7 changes: 1 addition & 6 deletions test-helpers/src/docker_compose.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ pub fn new_moto() -> DockerCompose {
docker_compose("tests/transforms/docker-compose-moto.yaml")
}

pub static IMAGE_WAITERS: [Image; 12] = [
pub static IMAGE_WAITERS: [Image; 11] = [
Image {
name: "motoserver/moto",
log_regex_to_wait_for: r"Press CTRL\+C to quit",
Expand Down Expand Up @@ -68,11 +68,6 @@ pub static IMAGE_WAITERS: [Image; 12] = [
log_regex_to_wait_for: r"Kafka Server started",
timeout: Duration::from_secs(120),
},
Image {
name: "bitnami/kafka:latest",
log_regex_to_wait_for: r"Kafka Server started",
timeout: Duration::from_secs(120),
},
Image {
name: "opensearchproject/opensearch:2.9.0",
log_regex_to_wait_for: r"Node started",
Expand Down

0 comments on commit 559d7ee

Please sign in to comment.