Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove todo #1374

Merged
merged 1 commit into from
Nov 23, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions shotover/src/transforms/protect/key_management.rs
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,6 @@ impl KeyManagerConfig {
grant_tokens,
endpoint,
} => Ok(KeyManager::AWSKms(AWSKeyManagement {
// TODO: This client is being recreated for each connection.
// but doing so is quite expensive so we should share it between all connections
// fortunately doing so is quite easy since all methods are `&self`
client: KmsClient::new(&config(region, endpoint).await),
cmk_id,
encryption_context,
Expand Down
Loading