Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove todo #1374

Merged
merged 1 commit into from
Nov 23, 2023
Merged

remove todo #1374

merged 1 commit into from
Nov 23, 2023

Conversation

conorbros
Copy link
Member

@conorbros conorbros commented Nov 23, 2023 •
edited
Loading

This todo has become irrelevant since the introduction of the TransformBuilder, a new client is not created with each new connection.

rukai
rukai approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find!

@rukai rukai merged commit 2000bb5 into shotover:main Nov 23, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rukai rukai rukai approved these changes

@cjrolo cjrolo cjrolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@conorbros @cjrolo @rukai