Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MISC] Use seqan::hibf::build::bin_size_in_bits #225

Merged
merged 1 commit into from
Oct 26, 2023
Merged

[MISC] Use seqan::hibf::build::bin_size_in_bits #225

merged 1 commit into from
Oct 26, 2023

Conversation

smehringer
Copy link
Member

No description provided.

@smehringer smehringer mentioned this pull request Oct 26, 2023
Merged
@seqan-actions seqan-actions added lint and removed lint labels Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7767b99) 95.94% compared to head (9dbf172) 95.93%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
- Coverage   95.94%   95.93%   -0.02%     
==========================================
  Files          19       19              
  Lines         690      688       -2     
==========================================
- Hits          662      660       -2     
  Misses         28       28
Files Coverage Δ
include/chopper/layout/hibf_statistics.hpp 94.11% <ø> (ø)
src/layout/hibf_statistics.cpp 98.96% <100.00%> (-0.01%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eseiler eseiler changed the title [MISC] Replace hibf::build::bin_size_in_bits where possible [MISC] Use seqan::hibf::build::bin_size_in_bits Oct 26, 2023
@seqan-actions seqan-actions added lint and removed lint labels Oct 26, 2023
@eseiler eseiler merged commit ec33f79 into seqan:main Oct 26, 2023
20 checks passed
@smehringer smehringer deleted the replace_function_bit_size branch October 26, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eseiler eseiler eseiler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smehringer @eseiler @seqan-actions