[FEATURE] update hibf lib and introduce --relaxed-fpr option. #223

smehringer · 2023-10-24T17:38:35Z

~~Blocked by #224~~
~~Blocked by #225~~

codecov · 2023-10-25T07:52:15Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e5e428) 95.93% compared to head (5f80522) 95.94%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
+ Coverage   95.93%   95.94%   +0.01%     
==========================================
  Files          19       19              
  Lines         688      691       +3     
==========================================
+ Hits          660      663       +3     
  Misses         28       28

Files	Coverage Δ
...layout/determine_best_number_of_technical_bins.cpp	`97.67% <100.00%> (+0.05%)`	⬆️
src/layout/hibf_statistics.cpp	`98.96% <100.00%> (-0.01%)`	⬇️
src/set_up_parser.cpp	`100.00% <100.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/util/display_layout/sizes.cpp

src/layout/hibf_statistics.cpp

src/layout/determine_best_number_of_technical_bins.cpp

test/api/display_layout/compute_ibf_size_test.cpp

seqan-actions added lint and removed lint labels Oct 24, 2023

smehringer force-pushed the update branch from 1478517 to 45fb7a3 Compare October 25, 2023 07:34

seqan-actions added lint and removed lint labels Oct 25, 2023

smehringer changed the title ~~[LIB] update hibf lib.~~ [FEATURE] update hibf lib and introduce --relaxed-fpr option. Oct 25, 2023

smehringer force-pushed the update branch from a9416fb to a5134ad Compare October 25, 2023 07:58

seqan-actions added lint and removed lint labels Oct 25, 2023

smehringer enabled auto-merge October 25, 2023 08:03

smehringer disabled auto-merge October 25, 2023 08:10

eseiler requested changes Oct 25, 2023

View reviewed changes

src/util/display_layout/sizes.cpp Outdated Show resolved Hide resolved

src/layout/hibf_statistics.cpp Outdated Show resolved Hide resolved

src/layout/determine_best_number_of_technical_bins.cpp Outdated Show resolved Hide resolved

smehringer force-pushed the update branch from a5134ad to b0be852 Compare October 26, 2023 18:27

seqan-actions added lint and removed lint labels Oct 26, 2023

smehringer force-pushed the update branch from 4702bd8 to 6a21fa6 Compare October 26, 2023 18:53

seqan-actions added lint and removed lint labels Oct 26, 2023

smehringer commented Oct 26, 2023

View reviewed changes

test/api/display_layout/compute_ibf_size_test.cpp Outdated Show resolved Hide resolved

smehringer and others added 3 commits October 26, 2023 21:07

[LIB] update hibf lib.

b9062a9

[FEATURE] Allow a --relaxed-fpr to reduce the memory footprint.

5aeebbf

[MISC] Also print relaxed fpr when determining best tmax.

5f80522

smehringer force-pushed the update branch from 552a904 to 5f80522 Compare October 26, 2023 19:07

seqan-actions added lint and removed lint labels Oct 26, 2023

smehringer requested a review from eseiler October 27, 2023 05:39

eseiler approved these changes Oct 27, 2023

View reviewed changes

eseiler merged commit 7823287 into seqan:main Oct 27, 2023
20 checks passed

smehringer deleted the update branch November 2, 2023 10:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEATURE] update hibf lib and introduce --relaxed-fpr option. #223

[FEATURE] update hibf lib and introduce --relaxed-fpr option. #223

smehringer commented Oct 24, 2023 •

edited

Loading

codecov bot commented Oct 25, 2023 •

edited

Loading

[FEATURE] update hibf lib and introduce --relaxed-fpr option. #223

[FEATURE] update hibf lib and introduce --relaxed-fpr option. #223

Conversation

smehringer commented Oct 24, 2023 • edited Loading

codecov bot commented Oct 25, 2023 • edited Loading

Codecov Report

smehringer commented Oct 24, 2023 •

edited

Loading

codecov bot commented Oct 25, 2023 •

edited

Loading