[MISC] Also print relaxed fpr when determining best tmax.

seqan · Oct 26, 2023 · 5f80522 · 5f80522
1 parent 5aeebbf
commit 5f80522
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/src/layout/determine_best_number_of_technical_bins.cpp b/src/layout/determine_best_number_of_technical_bins.cpp
@@ -57,7 +57,8 @@ determine_best_number_of_technical_bins(chopper::configuration & config)
     file_out << "## ### Parameters ###\n"
              << "## number of user bins = " << config.hibf_config.number_of_user_bins << '\n'
              << "## number of hash functions = " << config.hibf_config.number_of_hash_functions << '\n'
-             << "## false positive rate = " << config.hibf_config.maximum_fpr << '\n';
+             << "## maximum false positive rate = " << config.hibf_config.maximum_fpr << '\n'
+             << "## relaxed false positive rate = " << config.hibf_config.relaxed_fpr << '\n';
     hibf_statistics::print_header_to(file_out, config.output_verbose_statistics);
 
     double best_expected_HIBF_query_cost{std::numeric_limits<double>::infinity()};

diff --git a/test/api/layout/execute_with_estimation_test.cpp b/test/api/layout/execute_with_estimation_test.cpp
@@ -61,7 +61,8 @@ TEST(execute_estimation_test, few_ubs)
               R"expected_cout(## ### Parameters ###
 ## number of user bins = 8
 ## number of hash functions = 2
-## false positive rate = 0.05
+## maximum false positive rate = 0.05
+## relaxed false positive rate = 0.3
 ## ### Notation ###
 ## X-IBF = An IBF with X number of bins.
 ## X-HIBF = An HIBF with tmax = X, e.g a maximum of X technical bins on each level.
@@ -116,7 +117,8 @@ TEST(execute_estimation_test, many_ubs)
               R"expected_cout(## ### Parameters ###
 ## number of user bins = 96
 ## number of hash functions = 2
-## false positive rate = 0.05
+## maximum false positive rate = 0.05
+## relaxed false positive rate = 0.3
 ## ### Notation ###
 ## X-IBF = An IBF with X number of bins.
 ## X-HIBF = An HIBF with tmax = X, e.g a maximum of X technical bins on each level.
@@ -417,7 +419,8 @@ TEST(execute_estimation_test, many_ubs_force_all)
               R"expected_cout(## ### Parameters ###
 ## number of user bins = 96
 ## number of hash functions = 2
-## false positive rate = 0.05
+## maximum false positive rate = 0.05
+## relaxed false positive rate = 0.3
 ## ### Notation ###
 ## X-IBF = An IBF with X number of bins.
 ## X-HIBF = An HIBF with tmax = X, e.g a maximum of X technical bins on each level.
@@ -521,7 +524,8 @@ TEST(execute_estimation_test, with_rearrangement)
               R"expected_cout(## ### Parameters ###
 ## number of user bins = 196
 ## number of hash functions = 2
-## false positive rate = 0.05
+## maximum false positive rate = 0.05
+## relaxed false positive rate = 0.3
 ## ### Notation ###
 ## X-IBF = An IBF with X number of bins.
 ## X-HIBF = An HIBF with tmax = X, e.g a maximum of X technical bins on each level.

diff --git a/test/api/layout/hibf_statistics_test.cpp b/test/api/layout/hibf_statistics_test.cpp
@@ -187,7 +187,8 @@ TEST(execute_test, chopper_layout_statistics_determine_best_bins)
         R"expected_cout(## ### Parameters ###
 ## number of user bins = 10
 ## number of hash functions = 2
-## false positive rate = 0.05
+## maximum false positive rate = 0.05
+## relaxed false positive rate = 0.3
 ## ### Notation ###
 ## X-IBF = An IBF with X number of bins.
 ## X-HIBF = An HIBF with tmax = X, e.g a maximum of X technical bins on each level.