Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash using tooltip in adapter #93

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Crash using tooltip in adapter #93

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
adf35ca
chore: Update gradle plugin
Oct 19, 2017
3510d40
chore: Update libraries and move constants
Oct 19, 2017
e3a667c
fix: Do not delete tooltips while requesting layout
Oct 19, 2017
8855dc3
refactor: Do not post animation cancel
Oct 19, 2017
83b44a8
Merge commit '6d2225859dc49efa8eb00e690d2993a53cdcd010' into develop
eduardbosch Dec 20, 2018
5cdf57c
Merge branch 'develop' into feature/crash_using_tooltip_in_adapter
eduardbosch Dec 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion library/src/main/java/it/sephiroth/android/library/tooltip/Tooltip.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,15 @@ void removeFromParent() {
mPopup.dismiss();
mPopup = null;
} else {
((ViewGroup) parent).removeView(TooltipViewImpl.this);
ViewGroup parentViewGroup = (ViewGroup) parent;

// If layout is requested we should delay removing the view to avoid parent
// onLayout crash
if (parentViewGroup.isLayoutRequested()) {
postRemoveFromParentNow(parentViewGroup);
} else {
removeFromParentNow(parentViewGroup);
}
}
if (null != mShowAnimation && mShowAnimation.isStarted()) {
mShowAnimation.cancel();
Expand All @@ -618,6 +626,19 @@ private void removeCallbacks() {
mHandler.removeCallbacks(activateRunnable);
}

private void postRemoveFromParentNow(final ViewGroup parent) {
post(new Runnable() {
@Override
public void run() {
removeFromParentNow(parent);
}
});
}

private void removeFromParentNow(ViewGroup parent) {
parent.removeView(TooltipViewImpl.this);
}

@Override
public void remove() {
log(TAG, INFO, "[%d] remove()", mToolTipId);
Expand Down