Crash using tooltip in adapter #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 19, 2017
# Conflicts: # app/build.gradle # build.gradle # gradle.properties # library/build.gradle # library/src/main/java/it/sephiroth/android/library/tooltip/Tooltip.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi to all! 🎉
As commented on this issue #28, using tooltips in adapters can cause NullPointerException when the adapter requests an update.
The problem is that when the adapter updates, the Tooltip might be removed if the adapter removes the Tooltip anchor from the layout. If this process happens in the middle of a
FrameLayout.onLayout, that causes theonLayoutto iterate on null objects.By delaying the Tooltip remove from its parent, this problem is solved because we avoid deleting views in the middle of a layout request.
Crash example
https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/widget/FrameLayout.java#265
FrameLayoutcontinue iterating in 4 objects, but one of them is null and that causes this line to crash:https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/widget/FrameLayout.java#275