Fix batching after page navigation #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 92e118c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
silesky
reviewed
Aug 1, 2023
| @@ -7,23 +7,23 @@ | |||
| * | |||
| * adapted from https://stackoverflow.com/questions/3239834/window-onbeforeunload-not-working-on-the-ipad/52864508#52864508, | |||
| */ | |||
| export const onPageLeave = (cb: (...args: unknown[]) => void) => { | |||
| export const onPageChange = (cb: (...args: boolean[]) => void) => { | |||
There was a problem hiding this comment.
Nit:
This sig says that there are multiple bool args.
Type signature should just be (unloaded: boolean) => void
silesky
reviewed
Aug 1, 2023
| @@ -91,10 +91,10 @@ export default function batch( | |||
| }, timeout) | |||
| } | |||
|
|
|||
| onPageLeave(() => { | |||
| pageUnloaded = true | |||
| onPageChange((unloaded: boolean) => { | |||
There was a problem hiding this comment.
Nit: No need to put "boolean" here; that should be part of the fn signature type
silesky
approved these changes
Aug 1, 2023
This was referenced Aug 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug where if a user navigated to another page and then back, batching no longer worked. This was due to the 'pageUnloaded' variable never being set back to false.
yarn changeset. Read about changesets here).