Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batching does not work after tab switch #783

Closed
portiz-daitan opened this issue Feb 8, 2023 · 2 comments
Closed

Batching does not work after tab switch #783

portiz-daitan opened this issue Feb 8, 2023 · 2 comments

Comments

@portiz-daitan
Copy link

I noticed that the batching of events stopped to work when a tab switch occurs in the browser.
I think it's because of the pageUnloaded flag that is not being reset to false after onPageLeave is called. So, the logic here will be true, and the flush will be called instead of scheduleFlush
@ericbambach-qwickrate
Copy link

Bump. This is affecting our production install of segment. Is this being looked at at all?

@silesky
Copy link
Contributor

silesky commented Aug 1, 2023 •
edited
Loading

Hey guys! Update: a PR is up for review #915

I expect the fix to be merged in / published some time this week.

@silesky silesky closed this as completed Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@silesky @portiz-daitan @ericbambach-qwickrate