Update parity scale dependencies #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
haerdib
commented
Dec 7, 2023
| crate::scale_value::encode_as_type(&field, field.context, types, &mut actual_bytes) | ||
| .expect("should be able to encode properly"); | ||
| } | ||
| assert_eq!(actual_bytes, actual.field_bytes()); |
There was a problem hiding this comment.
This assert failed after upgrading the scale libraries and was removed in subxt as well. I simply followed suit, didn't look further into it. Since all the other tests are passing, I'm inclined to believe this is alright. Either way, there is a follow up issue: #688
haerdib
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated dependencies of
Removed local no-std copy of scale-value because it is now no-std compatible upstream as well. Therefore, added scale-value as dependency instead.
Minimal codebase adaptions were needed, but they still match the subxt version. There were further adaptions in subxt, but this will require more changes in our codebase, this should be done in a different issue: #688
part of #671