Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node-api parts #688

Closed
haerdib opened this issue Dec 7, 2023 · 1 comment · Fixed by #734
Closed

Update node-api parts #688

haerdib opened this issue Dec 7, 2023 · 1 comment · Fixed by #734
Assignees
Labels
F9-dependencies Pull requests that update a dependency file

Comments

@haerdib
Copy link
Contributor

haerdib commented Dec 7, 2023

We should check the following files are still up to date:

Follow up issue of #687

@haerdib haerdib added the F9-dependencies Pull requests that update a dependency file label Dec 7, 2023
@haerdib haerdib changed the title Update subxt parts Update node-api parts Dec 7, 2023
@masapr masapr assigned haerdib and unassigned masapr Feb 20, 2024
@haerdib
Copy link
Contributor Author

haerdib commented Feb 23, 2024

  • Events have been updated to the newest state in Add Encode Decode to ExtrsinicReport and use RawExtrinsicDetails #704. There have been no major changes.

  • check metadata. There are quite some differences as subxt now uses the fully self-defined metadata, while we are doing something in between using self-defined and directly from frame-metadata. I personally believe that using fully self-defined metadata is a no-go for us, as it would enforce instant updates once the metadata is updated. Lets keep it small and simple for now.

  • check error: There's been an update on side of parity. This needs to be adapted. Subxt has also updated the ModuleError to contain metadata. I don't think we should follow this update, as I'd rather keep the Errors small.

This was referenced Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F9-dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants