Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nightly from Rust lint checks #1688

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Remove nightly from Rust lint checks #1688

merged 4 commits into from
Nov 6, 2023

Conversation

emmiegit
Copy link
Member

@emmiegit emmiegit commented Nov 6, 2023

The regression with some builds, as well as issues we've had such as the aggressive unused imports lint resulted from nightly clippy. This also resulted in nightly builds, which is why we've had strange build regressions. Since clippy has been landed in stable for some time, we can just switch to that.

We could also merge the rustfmt and clippy steps into the main build group, but I'm not doing that for two reasons:

  1. Having a separate group is helpful for seeing at a glance what kind of build failures you have. If there's only one, you can't tell if the failure is "code isn't formatted" vs "it won't compile".
  2. There is the question of whether format checks should be before or after compilation. If they're before, then something like a missing comma can mean your build doesn't even try to compile, if it's after, then you might have to wait for the entire compilation to finish before seeing said comma is missing and you have to push a fix.

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #1688 (62394d4) into develop (34a9a22) will decrease coverage by 0.01%.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1688      +/-   ##
===========================================
- Coverage    40.18%   40.17%   -0.01%     
===========================================
  Files          342      342              
  Lines        10818    10818              
===========================================
- Hits          4347     4346       -1     
- Misses        6471     6472       +1     
Flag Coverage Δ *Carryforward flag
deepwell 2.07% <ø> (-0.02%) ⬇️
ftml 76.83% <ø> (ø) Carriedforward from 80fe0e7

*This pull request uses carry forward flags. Click here to find out more.

see 1 file with indirect coverage changes

@emmiegit emmiegit changed the title [WIP] Remove nightly from Rust lint checks Remove nightly from Rust lint checks Nov 6, 2023
@emmiegit emmiegit self-assigned this Nov 6, 2023
@emmiegit emmiegit requested a review from Zokhoi November 6, 2023 17:46
@emmiegit emmiegit marked this pull request as ready for review November 6, 2023 17:54
@emmiegit
Copy link
Member Author

emmiegit commented Nov 6, 2023

thanks @Zokhoi

@emmiegit emmiegit merged commit 95fcbef into develop Nov 6, 2023
11 checks passed
@emmiegit emmiegit deleted the no-nightly-clippy branch November 6, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants