Skip to content

Commit

Permalink
Merge pull request #1688 from scpwiki/no-nightly-clippy
Browse files Browse the repository at this point in the history
Remove nightly from Rust lint checks
  • Loading branch information
emmiegit authored Nov 6, 2023
2 parents 392fbc5 + 62394d4 commit 95fcbef
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 16 deletions.
10 changes: 2 additions & 8 deletions .github/workflows/deepwell.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ jobs:
uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: nightly
toolchain: stable
override: true
components: rustfmt, clippy

Expand All @@ -129,10 +129,4 @@ jobs:
run: cd deepwell && cargo fmt --all -- --check

- name: Clippy
run: cd deepwell && cargo clippy --no-deps -- -A unused_imports

# clippy is over aggressive with "unused import" warnings, reporting it for
# prelude modules and common export patterns, which is noisy and unhelpful.
#
# Since regular (i.e. actual) unused imports will fail the normal build, we
# can just suppress all unused import warnings in Clippy.
run: cd deepwell && cargo clippy --no-deps
6 changes: 2 additions & 4 deletions .github/workflows/ftml.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ jobs:
uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: nightly
toolchain: stable
override: true
components: rustfmt, clippy

Expand All @@ -156,6 +156,4 @@ jobs:
run: cd ftml && cargo fmt --all -- --check

- name: Clippy
run: cd ftml && cargo clippy --no-deps -- -A unused_imports

# See deepwell.yaml for explainer on unused_imports.
run: cd ftml && cargo clippy --no-deps
6 changes: 2 additions & 4 deletions .github/workflows/locales.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: nightly
toolchain: stable
override: true
components: rustfmt, clippy

Expand All @@ -65,6 +65,4 @@ jobs:
run: cd ftml && cargo fmt --all -- --check

- name: Clippy
run: cd ftml && cargo clippy --no-deps -- -A unused_imports

# See deepwell.yaml for explainer on unused_imports.
run: cd ftml && cargo clippy --no-deps

0 comments on commit 95fcbef

Please sign in to comment.