Add JSON metadata in PRs #3466
Merged
Add JSON metadata in PRs #3466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelmior
force-pushed
the
json-metadata
branch
from
a8e5181
to
563dbd0
Compare
|
I'm not sure what's going on with the CI failure since at first glance, it appears unrelated to this change. |
|
It appears that other test assertions needs changes (JSON metadata in PR description) too, just my 2 cents from quick look. |
michaelmior
force-pushed
the
json-metadata
branch
from
563dbd0
to
21dc0c5
Compare
michaelmior
force-pushed
the
json-metadata
branch
from
21dc0c5
to
a2a9a37
Compare
|
@exoego The remaining failing tests seem to be unrelated to my changes. |
|
The failing test are caused by your changes. |
michaelmior
force-pushed
the
json-metadata
branch
from
a2a9a37
to
b9d4106
Compare
|
@mzuehlke Thanks. I seemed to have missed that. I fixed those failing tests. |
mzuehlke
approved these changes
Nov 8, 2024
|
@mzuehlke Thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #3465. This ended up being quite straightforward as I didn't realize there was already a well-defined JSON serialization for updates. I think the only downside of this is a slightly larger payload that gets sent to GitHub each time a PR is created, but it does enable some interesting use cases of taking automated actions on the resulting PRs.