Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure PR description is not too long #3492

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

mzuehlke
Copy link
Member

@mzuehlke mzuehlke commented Dec 3, 2024

With the addition of structured metadata to PR description the content was growing too large when multiple updates got grouped together. Now the metadata gets only appended, if the length is still below 65536 characters.

Caused-by: #3466
Fixes: #3476

With the addition of structured metadata to PR description the content was growing too large when multiple updates got grouped together.
Now the metadata gets only appended, if the length is still below 65536 characters.

Fixes: #3476
@mzuehlke mzuehlke added this to the 0.31.2 milestone Dec 3, 2024
@mzuehlke mzuehlke added the bug Something isn't working label Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.66%. Comparing base (dce40bb) to head (5b1fa0f).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...lasteward/core/forge/data/NewPullRequestData.scala 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3492      +/-   ##
==========================================
- Coverage   89.67%   89.66%   -0.02%     
==========================================
  Files         171      171              
  Lines        3526     3530       +4     
  Branches      357      332      -25     
==========================================
+ Hits         3162     3165       +3     
- Misses        364      365       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alejandrohdezma alejandrohdezma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzuehlke mzuehlke merged commit e55a877 into main Dec 4, 2024
10 of 12 checks passed
@mzuehlke mzuehlke deleted the description-length-limit branch December 4, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PRs with descriptions longer than 65536 characters exceed GitHub API limits, fail the Scala Steward run
2 participants