-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Up next react sept 24 #933
Conversation
Note: need to update all the pr related libs again before test/merge |
Yup makes sense! Thanks @rin-st! Will review/test it as soon you push the update commit, also no rush at all!! |
Updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ @rin-st !! 🙌 Tested in vercel-sepolia and is working nicely to me.
In the vercel development site at some point I checked console and I was getting spamming errors, (I think they're related to Metamask) but I haven't noticed any bad behaviour.
Will try to reproduce later tonight, I tried a couple times and couldn't reproduce 🙏
wrote |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rin-st !! Tested it nicely and works great!
https://up-next-psi.vercel.app/
I was getting spamming errors, (I think they're related to Metamask) but I haven't noticed any bad behaviour.
Ohh I have kind of seen this sometime not sure why its happens but I think it happens only in rare cases that to on vercel gated URL's on actual open to all domains haven't encountered it. So feel nothing to very that much about but we could keep a look and tackle it sometime
Description
Step 2 of #917 (comment)
Decided to combine next/react with CSS libs or we will have 15 pull requests just to update dependencies
Plus
react-copy-to-clipboard
types since it's broken with newest reactvercel
versionviem
,wagmi
andrainbowkit
last patchesAdditional Information