-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shadcn rainbowkit button + dropdown #937
Conversation
Hey @rin-st thanks for such detailed explanation love it! I feel like we shouldn't touch the components added from shadcn yet(unti will we are in dev phase) and let them be stock as it is. Umm I don't want us to mimic daisyUI SE-2 with shadcn and keep it as stock as possible also avoid passing of extra ^ We can always polish stuff later and as you mentioned in #937 (comment) we are also not final on theme yet. When we update we can always again visit this things. Also the reason I say we keep things as close to shadcn without updating much is this will make adding shadcn stuff to SE-2 look more compatible when people start using it. For example if we update shadcn btn from rounded-md => rounded-full. Now if a developer using SE-2 plans to use Alert component from shadcn he has to manually update that component to bit more rounded. what do you say? Thanks @rin-st!! Also please fee free to push changes directly to that branch 🙌 |
It completely depends of our default styles. Like now, our buttons are always rounded, so when dev uses
But if we want to take default shadcn styles and change it later then ok, let's do it. |
Reverted ui changes and passing classNames But I'm not sure regarding the last. We will need to do this anyway, so looks like it's better to keep that classNames from the start, so we will not forget to change it in future. See, how it looks. With classnames: Screen.Recording.2024-09-18.at.15.03.09.movWithout classNames - trigger button padding, dropdown border, buttons width, disconnect color (we can make disconnect button type="destructive", but it will be with red bg, so not so good I think): Screen.Recording.2024-09-18.at.15.04.43.moveverything except buttons width is optional for now though |
Returned full width for menu items for now. Screen.Recording.2024-09-19.at.13.44.28.movMerging this, I think current state is good enough to move forward |
Description
Custom rainbowkit button + dropdown implemented with shadcn
See #937 (comment) and #937 (comment) first
Buttons functionality
Screen.Recording.2024-09-15.at.20.32.56.mov
With networks switch
Screen.Recording.2024-09-15.at.20.34.04.mov
Wrong network dropdown
Screen.Recording.2024-09-15.at.20.35.06.mov
Dark theme
Screen.Recording.2024-09-15.at.20.42.31.mov