Sbs titlepage tests #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't run the test suite either. |
|
Just like with sbsdev/pipeline-mod-sbs#9 I suggest we wait with merging this until we've solved the performance problem. |
|
Hm, I guess it is the more sensible thing to do. @mixa72 wanted to do some manual testing though. I guess he will have to wait or I can install a snapshot off the branch. |
|
Yes you could deploy off the branch, as long as Mischa knows that the next deployment will overwrite it again. |
at least for normal and rucksack
Before it was a mix of xslt and css which didn't really comply with the requirements. Now it is all moved to css where we can change the content based on the number of volumes.
right above the publisher blurb. This fixes the rucksack g2 tests.
The ppp series blurb should be there after all
bertfrees
force-pushed
the
sbs-titlepage-tests
branch
from
2e8ad28 to
d297718
Compare
bertfrees
force-pushed
the
sbs-titlepage-tests
branch
from
d297718 to
f778fee
Compare
|
Rebased this branch as "sbs-49". |
|
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the tests pass now and css and boiler-plate generation should be the way we want it