Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verso of title page has too many rows #49

Closed
bertfrees opened this issue Nov 1, 2016 · 3 comments
Closed

Verso of title page has too many rows #49

bertfrees opened this issue Nov 1, 2016 · 3 comments
Assignees

Comments

@bertfrees
Copy link
Contributor

bertfrees commented Nov 1, 2016

29 instead of 28. There are two issues here:

  • Dotify produces an invalid PEF. It should probably throw an error instead.

  • The CSS isn't very good because the goal is to position a block of text at the bottom of the page, but it is achieved by positioning an element (.series-ppp) that is not the last text on the page (publisher follows) at a certain vertical position. If for some reason the text takes more (or less) lines than we expect, the positioning is wrong.

    frontmatter > #cover-verso > .series-ppp {
        display: block;
        text-indent: 0;
        -obfl-vertical-position:19;
    }

    Better would be to wrap the whole thing in a block and position that block at the bottom of the page. Something like this:

    frontmatter > #cover-verso > #cover-verso-bottom {
        display: block;
        text-indent: 0;
        -obfl-vertical-position: 28;
        -obfl-vertical-align: before;
    }

@egli Maybe you can have a look at this while enabling the boilerplate tests?

@egli
Copy link
Member

egli commented Nov 17, 2016

This should be fixed now in sbsdev/pipeline#1

@bertfrees
Copy link
Contributor Author

bertfrees commented Nov 21, 2016

Fixed but can't deploy yet, see sbsdev/pipeline#1 (comment). EDIT 31/3: test suite works again (#52 (comment)).

@mixa72
Copy link

mixa72 commented Apr 4, 2017

Output ok now.

@mixa72 mixa72 closed this as completed Apr 4, 2017
@bertfrees bertfrees removed the 4 - Done label Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants