Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bug two #19

Merged
merged 34 commits into from
Nov 29, 2024
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
8f10765
wip: Add bug two
jvfe Oct 2, 2024
2ede707
refact: Try defaulting to a dict
jvfe Oct 14, 2024
7066463
fix: Dont allow remote to be unbound
jvfe Oct 14, 2024
c3b6acc
refact: Check if not equal to component type
jvfe Oct 24, 2024
484bea4
refact: Re-add isinstance dict
jvfe Oct 24, 2024
885e27b
fix: Remove mention of component_name
jvfe Oct 24, 2024
7b0f295
refact: Add special case for strings following dicts
jvfe Oct 24, 2024
c31c81b
test: Try removing branch from test case
jvfe Oct 24, 2024
a74facc
refact: Remove isinstance for str
jvfe Oct 24, 2024
7ebc6dc
refact: Use dict only with get_comps out
jvfe Oct 25, 2024
f7d3a4d
Revert "refact: Use dict only with get_comps out"
jvfe Oct 25, 2024
6982193
refact: Check if content has subwfs
jvfe Oct 25, 2024
a9b9184
refact: Always set current remote
jvfe Oct 25, 2024
046881a
refact: Check sha before resetting current_repo
jvfe Oct 28, 2024
0199e2d
refact: Do the negative test
jvfe Oct 28, 2024
955a1da
refact: Use another variable for remote
jvfe Oct 28, 2024
8ec9bbb
refact: Simplify check
jvfe Oct 28, 2024
0e35a85
refact: Expand check once again
jvfe Oct 28, 2024
959a63c
refact: Roll back to previous check
jvfe Oct 28, 2024
65aa1c4
fix: self.sha must not be none to reset to none
jvfe Oct 28, 2024
1e10b29
Revert "fix: self.sha must not be none to reset to none"
jvfe Oct 28, 2024
649fc64
Try removing the section entirely
jvfe Oct 29, 2024
c89e726
refact: Try moving check to reset
jvfe Nov 6, 2024
00996cb
refact: Remove unnecessary current_sha
jvfe Nov 7, 2024
4225272
refact: Change check in get_comps
jvfe Nov 7, 2024
e72de2f
refact: Set git remote beforehand
jvfe Nov 7, 2024
f58815e
refact: Change indent so previous check is the same
jvfe Nov 7, 2024
a956e04
refact: Remove current repo check
jvfe Nov 7, 2024
347ebcc
Revert "refact: Remove current repo check"
jvfe Nov 7, 2024
f20712c
refact: Try using name list
jvfe Nov 7, 2024
b4f9760
fix: Remove break in loop
jvfe Nov 29, 2024
38709da
refactor: Always set current_repo
jvfe Nov 29, 2024
45991f4
fix: Check if name is in updated
jvfe Nov 29, 2024
c0760a8
refactor: Remove unused sections and logs
jvfe Nov 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refact: Add special case for strings following dicts
  • Loading branch information
jvfe committed Oct 24, 2024
commit 7b0f29527ffecf4dcec63848ac697aaa332d3227
3 changes: 3 additions & 0 deletions nf_core/components/update.py
Original file line number Diff line number Diff line change
@@ -103,6 +103,9 @@ def update(self, component=None, silent=False, updated=None, check_diff_exist=Tr
self.modules_repo = ModulesRepo(remote_url, branch)
component = component["name"]

if isinstance(component, str):
self.modules_repo = ModulesRepo(self.current_remote, self.branch)

if self.current_remote == self.modules_repo.remote_url and self.sha is not None:
self.current_sha = self.sha
else:
Loading