Skip to content

Commit

Permalink
replaced all mentions of PDB-Dev with PDB-IHM; pdb-dev.wwpdb.org link…
Browse files Browse the repository at this point in the history
…s with pdb-ihm.org; bumped version to 1.2.1
  • Loading branch information
aozalevsky committed Nov 14, 2024
1 parent 412e6d0 commit 42d37ec
Show file tree
Hide file tree
Showing 13 changed files with 77 additions and 77 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Validation pipeline for integrative and hybrid models

## Project objective
- `1.` Develop a validation pipeline (including data validation, model validation, fit of input to model, fit of data not used for modeling and uncertainty of the model) for assessing IHM structures deposited to [PDB-Dev](https://pdb-dev.wwpdb.org/index.html)
- `1.` Develop a validation pipeline (including data validation, model validation, fit of input to model, fit of data not used for modeling and uncertainty of the model) for assessing IHM structures deposited to [PDB-IHM](https://pdb-ihm.org/index.html)

## List of files and directories:
- `docs` documentation for all classes and functions (sphinx)
Expand Down
6 changes: 3 additions & 3 deletions ihm_validation/generate_static_html_pages.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
help="Generate validation help page")
parser.add_argument('--output-root', type=str, default=str(Path(Path(__file__).parent.resolve(), 'Validation')),
help="Path to a directory where the output will be written")
# parser.add_argument('--html-mode', type=str, default='pdb-dev',
# choices=['local', 'pdb-dev'],
# parser.add_argument('--html-mode', type=str, default='pdb-ihm',
# choices=['local', 'pdb-ihm'],
# help="HTML mode affects paths to various statis resources")
# parser.add_argument('--html-resources',
# type=str,
Expand Down Expand Up @@ -66,7 +66,7 @@
templateEnv = jinja2.Environment(loader=templateLoader)
Template_Dict = {}
Template_Dict['version'] = REPORT_VERSION
Template_Dict['html_mode'] = 'pdb-dev'
Template_Dict['html_mode'] = 'pdb-ihm'

#############################################################################################################################
# Jinja scripts
Expand Down
2 changes: 1 addition & 1 deletion ihm_validation/get_plots.py
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ def plot_quality_at_glance(self, molprobity_data: dict, exv_data: dict,
fullplot = column(title, grid)

# if neither exc vol nor molp data exists, we create a blank plot
# pdb-dev visuals keep changing, so this plot might or might not make sense
# pdb-ihm visuals keep changing, so this plot might or might not make sense
# we are keeping it, just in case the visuals change again
else:
Scores = ['']
Expand Down
4 changes: 2 additions & 2 deletions ihm_validation/ihm_validator.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@
help="Path to a directory where the output will be written")
parser.add_argument('--output-prefix', type=str, default=None,
help="Prefix of the output directory. Default is a stem of the mmCIF file")
parser.add_argument('--html-mode', type=str, default='pdb-dev',
choices=['local', 'pdb-dev'],
parser.add_argument('--html-mode', type=str, default='pdb-ihm',
choices=['local', 'pdb-ihm'],
help="HTML mode affects paths to various statis resources")
parser.add_argument('--html-resources',
type=str,
Expand Down
2 changes: 1 addition & 1 deletion ihm_validation/molprobity.py
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ def run_molprobity(self, d: dict):
# "disable_uc_volume_vs_n_atoms_check=True",
# This is a legacy option and causes extremely
# large memory consumption with recent
# molprobity versions on PDB-Dev entries
# molprobity versions on PDB-IHM entries
"coot=False"],
stdout=f,
cwd=self.cache)
Expand Down
2 changes: 1 addition & 1 deletion ihm_validation/report.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
import numpy as np
from selenium import webdriver

REPORT_VERSION = '1.2'
REPORT_VERSION = '1.2.1'

class WriteReport(object):
def __init__(self, mmcif_file, db, cache, nocache=False):
Expand Down
6 changes: 3 additions & 3 deletions templates/about_validation.html
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<nav class="navbar navbar-expand-xl navbar-dark">
<div class="dropdown">
<a class="navbar-brand" href="/Validation/about.html">
<h5>About the PDB-Dev validation reports for integrative structures</h5>
<h5>About the PDB-IHM validation reports for integrative structures</h5>
</a>
<button class="navbar-toggler" type="button" data-toggle="collapse" data-target="#navbarSupportedContent" aria-controls="navbarSupportedContent" aria-expanded="false" aria-label="Toggle navigation">
<span class="navbar-toggler-icon"></span>
Expand All @@ -25,11 +25,11 @@ <h5>About the PDB-Dev validation reports for integrative structures</h5>
<div class="col-lg-12">
<div class="card-header" style="background-color: #E4E4E4;">
<p class=ex2 align='center'>
<b><u><a name='overview'>PDB-Dev Validation Report</a></u></b>
<b><u><a name='overview'>PDB-IHM Validation Report</a></u></b>
</p>

<p class=ex2 align='justify'>
This validation report was created based on guidelines and recommendations from IHM TaskForce <a href='https://pubmed.ncbi.nlm.nih.gov/31780431/'>(Berman et al. 2019)</a>. The first version of the PDB-Dev validation report consists of four categories, (i) model composition, (ii) data quality assessments, (iii) model quality assessments, and (iv) fit to data used to build the model. A fifth category, fit to data used to validate the model is under development.
This validation report was created based on guidelines and recommendations from IHM TaskForce <a href='https://pubmed.ncbi.nlm.nih.gov/31780431/'>(Berman et al. 2019)</a>. The first version of the PDB-IHM validation report consists of four categories, (i) model composition, (ii) data quality assessments, (iii) model quality assessments, and (iv) fit to data used to build the model. A fifth category, fit to data used to validate the model is under development.

Data quality assessments and fit to data used for modeling categories are dependent on the different types of experimental data used in integrative modeling. We are breaking down this section based on experimental data type and addressing each method separately. The first version of the validation report is focused on validating models built using Small Angle Scattering (SAS) data and is based on the model and data validation guidelines published by the <a href='https://www.wwpdb.org/task/sas'>wwPDB SAS validation task force</a> <a href='https://pubmed.ncbi.nlm.nih.gov/28876235/'>(Trewhella et al. 2017)</a>.
</p>
Expand Down
Loading

0 comments on commit 42d37ec

Please sign in to comment.