Deprecate startEngagementWithConfig method #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gersonnoboa
approved these changes
Nov 7, 2023
rasmustautsglia
requested review from
EgorovEI,
yurii-glia and
igorkravchenko
EgorovEI
reviewed
Nov 7, 2023
igorkravchenko
approved these changes
Nov 7, 2023
yurii-glia
approved these changes
Nov 7, 2023
rasmustautsglia
force-pushed
the
Deprecate-startEngagementWithConfig-method
branch
from
31f1975 to
6635dff
Compare
EgorovEI
reviewed
Nov 10, 2023
rasmustautsglia
requested review from
igorkravchenko,
gersonnoboa,
yurii-glia and
EgorovEI
EgorovEI
reviewed
Nov 10, 2023
| features: Features = .all, | ||
| sceneProvider: SceneProvider? = nil | ||
| ) throws { | ||
| try startEngagement( |
There was a problem hiding this comment.
Do we need to store theme there?
self.theme = theme
There was a problem hiding this comment.
Yes because if this is removed, the warning comes on and says this method is infinite recursion
|
I would also ask you to add unit test for applying RemoteConfiguration over Theme (few values would be enough). Just to ensure it's applied. |
yurii-glia
approved these changes
Nov 13, 2023
gersonnoboa
reviewed
Nov 13, 2023
| /// Deprectated, use ``Glia.startEngagement(engagementKind:in queueIds:features:sceneProvider:)`` instead. | ||
| /// Use ``configure(with configuration:uiConfig:assetsBuilder:completion:)`` to pass in ``RemoteConfiguration``. | ||
| @available(*, deprecated, message: """ | ||
| Deprectated, use ``Glia.startEngagement(engagementKind:in queueIds:features:sceneProvider:)`` instead. |
There was a problem hiding this comment.
fixed 768c529
| ) | ||
| } | ||
|
|
||
| /// Deprectated, use ``Glia.startEngagement(engagementKind:in queueIds:features:sceneProvider:)`` instead. |
There was a problem hiding this comment.
fixed 768c529
| /// Deprectated, use ``Glia.startEngagement(engagementKind:in queueIds:features:sceneProvider:)`` instead. | ||
| /// Use ``configure(with configuration:uiConfig:theme:assetsBuilder:completion:)`` to pass in ``RemoteConfiguration``. | ||
| @available(*, deprecated, message: """ | ||
| Deprectated, use ``Glia.startEngagement(engagementKind:in queueIds:features:sceneProvider:)`` instead. |
There was a problem hiding this comment.
fixed 768c529
| try Glia.sharedInstance.configure(with: configuration) { [weak self] result in | ||
| try Glia.sharedInstance.configure( | ||
| with: configuration, | ||
| theme: Theme() |
There was a problem hiding this comment.
Why does theme have to reconstructed here every time 'authenticate' is tapped?
There was a problem hiding this comment.
Because if I remove this parameter, Xcode picks the old configure method instead and deprecation warning appears.
EgorovEI
approved these changes
Nov 13, 2023
|
!squash |
sm-deployer
force-pushed
the
Deprecate-startEngagementWithConfig-method
branch
from
e424849 to
c7c4b99
Compare
This PR deprecates startEngagementWithConfig method and moves it to deprecated methods file MOB-2817
rasmustautsglia
force-pushed
the
Deprecate-startEngagementWithConfig-method
branch
from
c7c4b99 to
c4f297e
Compare
rasmustautsglia
deleted the
Deprecate-startEngagementWithConfig-method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue:
https://glia.atlassian.net/browse/MOB-2817
What was solved?
This PR deprecates startEngagementWithConfig method and moves it to the deprecated methods file. This PR also replaces configure method with new one that takes Theme as a parameter. In addition, startEngagement method is deprecated and replaced with a new one that doesn't have Theme as parameter.
Release notes:
Additional info:
Screenshots: