Skip to content

Commit

Permalink
fixup! Deprecate startEngagementWithConfig method
Browse files Browse the repository at this point in the history
This PR deprecates startEngagementWithConfig method and moves it to
deprecated methods file

MOB-2817
  • Loading branch information
rasmustautsglia committed Nov 13, 2023
1 parent 768c529 commit e424849
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions GliaWidgets/Public/Glia/Glia.Deprecated.swift
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,7 @@ extension Glia {
features: Features = .all,
sceneProvider: SceneProvider? = nil
) throws {
self.theme = theme
try startEngagement(
engagementKind: engagementKind,
in: queueIds,
Expand Down
8 changes: 4 additions & 4 deletions GliaWidgetsTests/Sources/Glia/GliaTests+StartEngagement.swift
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,9 @@ extension GliaTests {
theme.call.connect.queue.firstText = "Glia 1"
theme.chat.connect.queue.firstText = "Glia 2"

try sdk.configure(with: .mock()) {
try sdk.configure(with: .mock(), theme: theme) { _ in
do {
try sdk.startEngagement(engagementKind: .chat, in: ["queueId"], theme: theme)
try sdk.startEngagement(engagementKind: .chat, in: ["queueId"])
} catch {
XCTFail("startEngagement unexpectedly failed with error \(error), but should succeed instead.")
}
Expand Down Expand Up @@ -275,9 +275,9 @@ extension GliaTests {
theme.call.connect.queue.firstText = "Glia 1"
theme.chat.connect.queue.firstText = "Glia 2"

try sdk.configure(with: .mock()) {
try sdk.configure(with: .mock(), theme: theme) { _ in
do {
try sdk.startEngagement(engagementKind: .chat, in: ["queueId"], theme: theme)
try sdk.startEngagement(engagementKind: .chat, in: ["queueId"])
} catch {
XCTFail("startEngagement unexpectedly failed with error \(error), but should succeed instead.")
}
Expand Down

0 comments on commit e424849

Please sign in to comment.