Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAK-50164 Double scrollbars at bottom of Gradebook are not user-friendly #13017

Open
wants to merge 1 commit into
base: 23.x
Choose a base branch
from
+2 −1
Open

SAK-50164 Double scrollbars at bottom of Gradebook are not user-friendly #13017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions library/src/skins/default/src/sass/modules/tool/gradebook/_gradebook.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#gradebookSpreadsheet,
#gradebookGradesToolbar {
margin-top: 15px;
overflow-x: hidden;
}
#gradeTableWrapper {
position: relative;
Expand Down
2 changes: 1 addition & 1 deletion portal/portal-render-engine-impl/impl/src/webapp/vm/morpheus/includePage.vm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
#else
#set( $numberTools = $pageColumn0Tools.size() )
#end
<div class="portal-main-container container-fluid mt-2">
<div class="portal-main-container container-fluid mt-2 d-flex flex-column">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is specific to the gradebook table, so changes should be made in gradebook-tool. I don’t think we need to update the entire portal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The portal-main-container changes were a part of SAK-50454 that were not merged in 23.x. Hence, I added it here as well and made changes for the gradebook tool specifically (overflow-x: hidden in gradebookGradesToolbar).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation, @i-a-m-s-k! It looks like SAK-50454 may be merged into 23.x soon, which could lead to a conflict. I'll check in with @ern on this.

<main id="$pageWrapperClass" class="portal-main-content #if( $numberTools > 1 || $homePage)Mrphs-multipleTools #end" role="main">
<h2 class="skip visually-hidden" tabindex="-1" id="tocontent">${rloader.sit_contentshead}</h2>
#parse("/vm/morpheus/includeSiteHierarchy.vm")
Expand Down
Loading