SAK-50164 Double scrollbars at bottom of Gradebook are not user-friendly #13017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunaljaykam
reviewed
Nov 12, 2024
| @@ -28,7 +28,7 @@ | |||
| #else | |||
| #set( $numberTools = $pageColumn0Tools.size() ) | |||
| #end | |||
| <div class="portal-main-container container-fluid mt-2"> | |||
| <div class="portal-main-container container-fluid mt-2 d-flex flex-column"> | |||
There was a problem hiding this comment.
The issue is specific to the gradebook table, so changes should be made in gradebook-tool. I don’t think we need to update the entire portal.
There was a problem hiding this comment.
The portal-main-container changes were a part of SAK-50454 that were not merged in 23.x. Hence, I added it here as well and made changes for the gradebook tool specifically (overflow-x: hidden in gradebookGradesToolbar).
There was a problem hiding this comment.
Thanks for the explanation, @i-a-m-s-k! It looks like SAK-50454 may be merged into 23.x soon, which could lead to a conflict. I'll check in with @ern on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added d-flex and flex-column bootstrap classes. In addition, added an overflow-x: hidden to _gradebook.scss. There is no additional scroll bar on web desktop screen now for Gradebook tool. Only one scrollbar is present for the table.