Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: add help link in footer #2822

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Fix: add help link in footer #2822

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14489c0
Fix: add help link in footer
katspaugh Nov 20, 2023
1183e6c
External link
katspaugh Nov 20, 2023
5d4592f
Merge branch 'dev' of github.com:safe-global/safe-wallet-web into help
katspaugh Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/components/common/Footer/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import packageJson from '../../../../package.json'
import AppstoreButton from '../AppStoreButton'
import ExternalLink from '../ExternalLink'
import MUILink from '@mui/material/Link'
import { IS_DEV, IS_OFFICIAL_HOST } from '@/config/constants'
import { HELP_CENTER_URL, IS_DEV, IS_OFFICIAL_HOST } from '@/config/constants'

const footerPages = [
AppRoutes.welcome.index,
Expand Down Expand Up @@ -67,6 +67,9 @@ const Footer = (): ReactElement | null => {
<li>
<FooterLink href={getHref(AppRoutes.settings.index)}>Preferences</FooterLink>
</li>
<li>
<FooterLink href={HELP_CENTER_URL}>Help</FooterLink>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to make it an external link and open in a new tab. Should we also track its usage?

</li>
</>
) : (
<li>{'This is an unofficial distribution of Safe{Wallet}'}</li>
Expand Down
Loading