Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add help link in footer #2822

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Fix: add help link in footer #2822

merged 3 commits into from
Nov 20, 2023

Conversation

katspaugh
Copy link
Member

What it solves

Otherwise, there's no way to access the Help page form the welcome page.

Screenshot 2023-11-20 at 11 09 10

Copy link

github-actions bot commented Nov 20, 2023

Branch preview

✅ Deploy successful!

https://help--walletweb.review-wallet-web.5afe.dev

Copy link

github-actions bot commented Nov 20, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 20, 2023

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.4 MB (🟡 +612 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps 34.59 KB (🟢 -240 B) 1.43 MB
/apps/custom 27.12 KB (🟢 -239 B) 1.43 MB
/home 23.63 KB (🟢 -236 B) 1.42 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Nov 20, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 75.13% 10094/13436
🔴 Branches 49.7% 2051/4127
🔴 Functions 57.62% 1504/2610
🟡 Lines 76.71% 9125/11896

Test suite run success

1105 tests passing in 155 suites.

Report generated by 🧪jest coverage report action from 5d4592f

@@ -67,6 +67,9 @@ const Footer = (): ReactElement | null => {
<li>
<FooterLink href={getHref(AppRoutes.settings.index)}>Preferences</FooterLink>
</li>
<li>
<FooterLink href={HELP_CENTER_URL}>Help</FooterLink>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to make it an external link and open in a new tab. Should we also track its usage?

@liliya-soroka
Copy link
Member

Verified

@katspaugh katspaugh merged commit 82b0848 into dev Nov 20, 2023
15 checks passed
@katspaugh katspaugh deleted the help branch November 20, 2023 15:14
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2023
@katspaugh katspaugh added this to the 1.23.0 milestone Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants