-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netfunnel -> already completed error #278
Merged
Merged
Changes from 7 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
93c38f0
add ALREADY_COMPLETED status
pisik9 09aa435
Update passenger.py
pisik9 053c3d2
Update reserve basic payload data
pisik9 a11aa49
change description
pisik9 d6e4016
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 75c1d7b
change typo
pisik9 092fd5c
code -> psgidx
pisik9 6083f65
update reserve basic data (SeatAttCd) / change reserveType
pisik9 23493dc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] bf68528
remove unnecessary data in reserve payload
pisik9 e09f2d5
remove unused variable(passengersCount)
pisik9 14b67cf
Update test_passenger.py
pisik9 b1bb51a
Update test_passenger.py
ryanking13 c21d4ec
Update test_passenger.py
ryanking13 217f136
Update test_passenger.py
ryanking13 75bf5cc
Update test_passenger.py
ryanking13 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -78,22 +78,22 @@ def get_passenger_dict( | |
"totPrnb": Passenger.total_count(passengers), | ||
"psgGridcnt": str(len(passengers)), | ||
} | ||
for _, passenger in enumerate(passengers): | ||
code = passenger.type_code | ||
data[f"psgTpCd{code}"] = passenger.type_code | ||
data[f"psgInfoPerPrnb{code}"] = str(passenger.count) | ||
for idx, passenger in enumerate(passengers): | ||
psgidx = idx + 1 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 감사합니다. 이 동작이 맞는지 한 번 다시 확인해볼게요. |
||
data[f"psgTpCd{psgidx}"] = passenger.type_code | ||
data[f"psgInfoPerPrnb{psgidx}"] = str(passenger.count) | ||
# seat location ('000': 기본, '012': 창측, '013': 복도측) | ||
data[f"locSeatAttCd{code}"] = WINDOW_SEAT[window_seat] | ||
data[f"locSeatAttCd{psgidx}"] = WINDOW_SEAT[window_seat] | ||
# seat requirement ('015': 일반, '021': 휠체어) | ||
# TODO: 선택 가능하게 | ||
data[f"rqSeatAttCd{code}"] = "015" | ||
data[f"rqSeatAttCd{psgidx}"] = "015" | ||
# seat direction ('009': 정방향) | ||
data[f"dirSeatAttCd{code}"] = "009" | ||
data[f"dirSeatAttCd{psgidx}"] = "009" | ||
|
||
data[f"smkSeatAttCd{code}"] = "000" | ||
data[f"etcSeatAttCd{code}"] = "000" | ||
data[f"smkSeatAttCd{psgidx}"] = "000" | ||
data[f"etcSeatAttCd{psgidx}"] = "000" | ||
# seat type: ('1': 일반실, '2': 특실) | ||
data[f"psrmClCd{code}"] = "2" if special_seat else "1" | ||
data[f"psrmClCd{psgidx}"] = "2" if special_seat else "1" | ||
|
||
return data | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -452,8 +452,8 @@ def _reserve( | |
"arvTm1": train.arr_time, # 도착일자1 (열차 목록 값) | ||
"totPrnb": passengersCount, # 승차인원 | ||
"psgGridcnt": passengersCount, # 승차인원 | ||
"psgTpCd1": passengersCount, # 승차인원 | ||
"psgInfoPerPrnb1": passengersCount, # 승차인원 | ||
"psgTpCd1": "0", # 승객종류1 passenger.code (psgTpCd1~5, 1~5) | ||
"psgInfoPerPrnb1": "0", # 승객종류1 인원수 (psgInfoPerPrnb1~5) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. passenger 객체에서 만들어줘서 넘어오니 이 부분은 그냥 없애도 될 것 같습니다 (totPrnb, psgGridcnt, psgTpCd1, psgInfoPerPrnb1, 등등) |
||
"trnNo1": "%05d" % int(train.train_number), # 열차번호1 (열차 목록 값) | ||
"runDt1": train.dep_date, # 운행일자1 (열차 목록 값) | ||
"psrmClCd1": "2" if is_special_seat is True else "1", | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍