netfunnel -> already completed error #278
Open
+26
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pass "already completed" error (it occurs trying _set_complete method multiple times in short durartion)
change description and default value of "psgTpCd1", "psgInfoPerPrnb1"
for more information, see https://pre-commit.ci
ryanking13
reviewed
Dec 17, 2024
| if netfunnel_resp.get("status") != self.WAIT_STATUS_PASS: | ||
| if netfunnel_resp.get("status") not in [ | ||
| self.WAIT_STATUS_PASS, | ||
| self.ALREADY_COMPLETED, |
| data[f"psgTpCd{code}"] = passenger.type_code | ||
| data[f"psgInfoPerPrnb{code}"] = str(passenger.count) | ||
| for idx, passenger in enumerate(passengers): | ||
| psgidx = idx + 1 |
There was a problem hiding this comment.
감사합니다. 이 동작이 맞는지 한 번 다시 확인해볼게요.
smk/dir/loc/rq/etc SeatAttCd1, 2는 간편예매에서 변경되는 값으로, 일반 예매에서는 고정값 reserveType은 11로 확인됨
for more information, see https://pre-commit.ci
ryanking13
approved these changes
Dec 18, 2024
Comment on lines
+455
to
+456
| "psgTpCd1": "0", # 승객종류1 passenger.code (psgTpCd1~5, 1~5) | ||
| "psgInfoPerPrnb1": "0", # 승객종류1 인원수 (psgInfoPerPrnb1~5) |
There was a problem hiding this comment.
passenger 객체에서 만들어줘서 넘어오니 이 부분은 그냥 없애도 될 것 같습니다 (totPrnb, psgGridcnt, psgTpCd1, psgInfoPerPrnb1, 등등)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-> get_passenger_dict 에서 passenger code가 아닌 순서대로 1~5로 생성되게 수정