Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare 1.28.0: step 2 #4098

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Prepare 1.28.0: step 2 #4098

merged 4 commits into from
Dec 2, 2024

Conversation

djc
Copy link
Contributor

@djc djc commented Nov 25, 2024 •
edited
Loading

Step 2 in our release process:

  • Update the commit shasum in rustup-init.sh to match the latest commit on master.

@djc djc requested review from ChrisDenton and rami3l November 25, 2024 15:15
@djc djc mentioned this pull request Nov 25, 2024
Merged
3 tasks
ChrisDenton
ChrisDenton approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@ChrisDenton ChrisDenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I have one query but I don't want to block on it.

rustup-init.sh Outdated Show resolved Hide resolved
rami3l
rami3l approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@rami3l rami3l left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djc Thanks a lot!

BTW are you planning to cut a beta release this week?

@djc
Copy link
Contributor Author

djc commented Nov 26, 2024

@djc Thanks a lot!

BTW are you planning to cut a beta release this week?

I plan to keep working towards it, don't have any kind of deadline in mind.

@djc djc added this pull request to the merge queue Nov 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2024
@djc djc added this pull request to the merge queue Nov 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2024
rami3l
rami3l approved these changes Nov 26, 2024
View reviewed changes
rustup-init.sh Outdated Show resolved Hide resolved
@rami3l rami3l added this to the 1.28.0 milestone Nov 26, 2024
@djc djc enabled auto-merge November 27, 2024 09:31
@rami3l
Copy link
Member

rami3l commented Nov 27, 2024 •
edited
Loading

@djc These CI errors have also influenced #4070 (comment).

#5 0.935 E: The repository 'http://archive.ubuntu.com/ubuntu lunar-updates Release' no longer has a Release file.

lunar means Ubuntu 23.04 which have, I believe, already been EOL for quite a while now. Not sure why our upstream still hasn't updated it...

This was referenced Nov 27, 2024
Closed
Merged
@rami3l
Copy link
Member

rami3l commented Dec 2, 2024

@djc These CI errors have also influenced #4070 (comment).

#5 0.935 E: The repository 'http://archive.ubuntu.com/ubuntu lunar-updates Release' no longer has a Release file.

lunar means Ubuntu 23.04 which have, I believe, already been EOL for quite a while now. Not sure why our upstream still hasn't updated it...

It took quite a while, but my rust-lang/rust#133532 has finally been merged! I guess we can restart the release process now.

@djc djc added this pull request to the merge queue Dec 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2024
@rami3l
Copy link
Member

rami3l commented Dec 2, 2024 •
edited
Loading

Oh, it's quite unfortunate since we're getting a Rust version bump in the middle of this PR, so we're introducing unresolved lints to the codebase...

@rami3l rami3l enabled auto-merge December 2, 2024 02:48
@rami3l rami3l added this pull request to the merge queue Dec 2, 2024
Merged via the queue into master with commit 1f97744 Dec 2, 2024
27 checks passed
@rami3l rami3l deleted the prepare-1.28-2 branch December 2, 2024 03:12
@rami3l rami3l mentioned this pull request Dec 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rami3l rami3l rami3l approved these changes

@ChrisDenton ChrisDenton ChrisDenton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.28.0
Development

Successfully merging this pull request may close these issues.
3 participants
@djc @rami3l @ChrisDenton