Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 1.28.0 release #4079

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Prepare 1.28.0 release #4079

merged 2 commits into from
Nov 25, 2024

Conversation

djc
Copy link
Contributor

@djc djc commented Nov 15, 2024

This is the 1st PR for the 1.28.0 release according to our release process.

Checklist

  • Bump version in the manifest.
  • Update the changelog.
  • Draft the release blog post (Not required, since we're doing a beta release).

CHANGELOG.md Show resolved Hide resolved
@ChrisDenton
Copy link
Member

Also

rustup-init 1.27.1 (a8e4f5c64 2024-04-24)
?

@rami3l rami3l added this to the 1.28.0 milestone Nov 15, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@rami3l
Copy link
Member

rami3l commented Nov 15, 2024

Also

rustup-init 1.27.1 (a8e4f5c64 2024-04-24)

?

@ChrisDenton Thanks for pointing it out! That's part of the plan, yeah, but it cannot be done in this PR for technical reasons. (It should be done right after this PR though.)

Copy link
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few points I'd like to add, but this is looking wonderful. Many thanks!

CHANGELOG.md Outdated Show resolved Hide resolved
@djc
Copy link
Contributor Author

djc commented Nov 19, 2024

There are a few points I'd like to add, but this is looking wonderful. Many thanks!

Do you mean the addition of Chris to the team? If there are other things you'd like to add, now would be a good time to mention that, I think?

@djc djc force-pushed the prepare-1.28.0 branch 2 times, most recently from adb19a5 to 07bdcf7 Compare November 19, 2024 10:21
@djc
Copy link
Contributor Author

djc commented Nov 19, 2024

There are a few points I'd like to add, but this is looking wonderful. Many thanks!

Do you mean the addition of Chris to the team? If there are other things you'd like to add, now would be a good time to mention that, I think?

Addressed the issues you've mentioned so far!

Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

CHANGELOG.md Show resolved Hide resolved
@rami3l
Copy link
Member

rami3l commented Nov 19, 2024

There are a few points I'd like to add, but this is looking wonderful. Many thanks!

Do you mean the addition of Chris to the team? If there are other things you'd like to add, now would be a good time to mention that, I think?

Addressed the issues you've mentioned so far!

@djc That has been all. Thanks a lot! If anything happens, we can still modify the changelog during the beta testing period :)

@djc
Copy link
Contributor Author

djc commented Nov 25, 2024

@ChrisDenton did you have any other feedback here? (Since you haven't explicitly approved.)

Copy link
Member

@ChrisDenton ChrisDenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from me.

Given the long list of changes, I did want to make sure there wasn't anything else worth calling out. But nothing jumps out at me.

@djc djc added this pull request to the merge queue Nov 25, 2024
@rami3l
Copy link
Member

rami3l commented Nov 25, 2024

@ChrisDenton did you have any other feedback here? (Since you haven't explicitly approved.)

@djc Just don't forget to update the changelog, since we've made some other changes as well since the last commit on this branch. Of course, it can be made into the actual release PR as well :)

Merged via the queue into master with commit b6fdf2f Nov 25, 2024
27 checks passed
@djc djc deleted the prepare-1.28.0 branch November 25, 2024 13:27
@djc
Copy link
Contributor Author

djc commented Nov 25, 2024

Next step in #4098.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants