-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 1.28.0 release #4079
Prepare 1.28.0 release #4079
Conversation
Also Line 36 in c8eddcb
|
@ChrisDenton Thanks for pointing it out! That's part of the plan, yeah, but it cannot be done in this PR for technical reasons. (It should be done right after this PR though.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few points I'd like to add, but this is looking wonderful. Many thanks!
Do you mean the addition of Chris to the team? If there are other things you'd like to add, now would be a good time to mention that, I think? |
adb19a5
to
07bdcf7
Compare
Addressed the issues you've mentioned so far! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@djc That has been all. Thanks a lot! If anything happens, we can still modify the changelog during the beta testing period :) |
@ChrisDenton did you have any other feedback here? (Since you haven't explicitly approved.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 from me.
Given the long list of changes, I did want to make sure there wasn't anything else worth calling out. But nothing jumps out at me.
@djc Just don't forget to update the changelog, since we've made some other changes as well since the last commit on this branch. Of course, it can be made into the actual release PR as well :) |
Next step in #4098. |
This is the 1st PR for the
1.28.0
release according to our release process.Checklist
Draft the release blog post(Not required, since we're doing a beta release).