Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Optimise Docker Caching #121165

Closed
wants to merge 1 commit into from
Closed

[DRAFT] Optimise Docker Caching #121165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/ci/docker/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ export MSYS_NO_PATHCONV=1
script=`cd $(dirname $0) && pwd`/`basename $0`

image=""

dev=0

while [[ $# -gt 0 ]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Author

@geektype geektype Feb 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a dummy commit.

Going to mess around with the CI so gonna use this PR to trigger builds. Let me know if there is a better way (this does feel hacky)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker caching isn't used at all on PR CI workflows. It is only used on master merges, where CI has credentials to actually access the cache. This can be tested only using a try build (that we can run for you manually), or (ideally), on your own fork of rust-lang/rust.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I will close this PR in that case!

Expand Down
Loading