-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] Optimise Docker Caching #121165
[DRAFT] Optimise Docker Caching #121165
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Kobzol (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
r? ghost |
Failed to set assignee to
|
@@ -7,6 +7,7 @@ export MSYS_NO_PATHCONV=1 | |||
script=`cd $(dirname $0) && pwd`/`basename $0` | |||
|
|||
image="" | |||
|
|||
dev=0 | |||
|
|||
while [[ $# -gt 0 ]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a dummy commit.
Going to mess around with the CI so gonna use this PR to trigger builds. Let me know if there is a better way (this does feel hacky)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docker caching isn't used at all on PR CI workflows. It is only used on master merges, where CI has credentials to actually access the cache. This can be tested only using a try build (that we can run for you manually), or (ideally), on your own fork of rust-lang/rust
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. I will close this PR in that case!
Addresses rust-lang/infra-team#103.