-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added epoll and eventfd for Android #4016
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiif
reviewed
Nov 7, 2024
RalfJung
reviewed
Nov 9, 2024
@rustbot author |
rustbot
added
the
S-waiting-on-author
Status: Waiting for the PR author to address review comments
label
Nov 9, 2024
YohDeadfall
force-pushed
the
android-epoll
branch
from
November 11, 2024 15:58
23c7c4b
to
731494f
Compare
@rustbot review |
rustbot
added
S-waiting-on-review
Status: Waiting for a review to complete
and removed
S-waiting-on-author
Status: Waiting for the PR author to address review comments
labels
Nov 11, 2024
☔ The latest upstream changes (presumably #4029) made this pull request unmergeable. Please resolve the merge conflicts. |
YohDeadfall
force-pushed
the
android-epoll
branch
from
November 12, 2024 09:37
731494f
to
1f5c4e5
Compare
☔ The latest upstream changes (presumably #3939) made this pull request unmergeable. Please resolve the merge conflicts. |
YohDeadfall
force-pushed
the
android-epoll
branch
2 times, most recently
from
November 19, 2024 10:28
a27dced
to
e3a980c
Compare
☔ The latest upstream changes (presumably #4049) made this pull request unmergeable. Please resolve the merge conflicts. |
YohDeadfall
force-pushed
the
android-epoll
branch
from
November 25, 2024 19:43
e3a980c
to
9ed1605
Compare
Thanks! |
This was referenced Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3996.
I decided not to move
check_shim
into the implementations because all these functions are no more than just shims oversyscall
. Moreover,eventfd
is even used by thesyscall
implementation.