-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move FdTable to a common location and split off Unix behavior #4045
Conversation
ff8b9b7
to
2a20dba
Compare
@sivadeilra - here's one of the PRs related to adding Miri support for Windows FS APIs, RE: #3482 |
What are you referring to here? |
☔ The latest upstream changes (presumably #4016) made this pull request unmergeable. Please resolve the merge conflicts. |
2a20dba
to
ddfa3a8
Compare
This is now 3 commits - the first only moves the FdMap, the seconds splits out Unix functionality, the third makes the |
@CraftSpider Thanks! @rustbot author (write |
ddfa3a8
to
d0c5f6b
Compare
@rustbot ready |
@rustbot author |
@rustbot ready |
Looks good, thanks! Please squash the last 2 commits in the previous ones (but definitely leave the first commit separate). |
5c14e0c
to
9fd1e13
Compare
9fd1e13
to
9e87420
Compare
@rustbot ready |
I'm open to instead keeping all the functions on the base trait, but this seemed like an easy way to keep them clearly only intended to be used in the unix shims.
Preparation for Windows FS support, see #4043