Skip to content

Commit

Permalink
Merge pull request #112 from jdno/format-and-lint
Browse files Browse the repository at this point in the history
Format and lint files in this repository
  • Loading branch information
jdno authored Apr 11, 2024
2 parents c107c55 + 8dfba06 commit f622105
Show file tree
Hide file tree
Showing 21 changed files with 385 additions and 182 deletions.
15 changes: 15 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
root = true

[*]
charset = utf-8
end_of_line = lf
insert_final_newline = true
max_line_length = 80
trim_trailing_whitespace = true

[*.md]
trim_trailing_whitespace = false

[*.{yml,yaml}]
indent_size = 2
indent_style = space
24 changes: 24 additions & 0 deletions .github/workflows/json.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
---
name: JSON

"on":
push:
branches:
- main
pull_request:
workflow_dispatch:

jobs:
style:
name: Check style
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Run prettier
uses: creyD/[email protected]
with:
dry: true
prettier_options: "--check **/*.json"
37 changes: 37 additions & 0 deletions .github/workflows/markdown.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
---
name: Markdown

"on":
push:
branches:
- main
pull_request:
workflow_dispatch:

jobs:
lint:
name: Lint code
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Run markdownlint
uses: nosborn/[email protected]
with:
files: "**.md"

style:
name: Check style
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Run prettier
uses: creyD/[email protected]
with:
dry: true
prettier_options: "--check **/*.md"
35 changes: 35 additions & 0 deletions .github/workflows/yaml.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
---
name: YAML

"on":
push:
branches:
- main
pull_request:
workflow_dispatch:

jobs:
lint:
name: Lint code
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Run yamllint
uses: actionshub/[email protected]

style:
name: Check style
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Run prettier
uses: creyD/[email protected]
with:
dry: true
prettier_options: "--check **/*.{yml,yaml}"
31 changes: 31 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# pre-commit configuration
#
# We use pre-commit to enforce a consistency in our repositories. By default,
# YAML and Markdown files get linted, and Prettier runs to auto-format the file
# types it supports. Depending on the project, other rules can be added here to
# support the needs of the project.
#
# See https://pre-commit.com for more information
# See https://pre-commit.com/hooks.html for more hooks
---
repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.6.0
hooks:
- id: check-added-large-files
- id: check-case-conflict
- id: end-of-file-fixer
- id: trailing-whitespace
args: [--markdown-linebreak-ext=md]
- repo: https://github.com/igorshubovych/markdownlint-cli
rev: v0.39.0
hooks:
- id: markdownlint
- repo: https://github.com/adrienverge/yamllint
rev: v1.35.1
hooks:
- id: yamllint
- repo: https://github.com/pre-commit/mirrors-prettier
rev: v3.1.0
hooks:
- id: prettier
1 change: 1 addition & 0 deletions .prettierrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{}
7 changes: 7 additions & 0 deletions .yamllint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
extends: default

rules:
line-length:
ignore: |
.github/workflows/*
3 changes: 2 additions & 1 deletion meetings/2019-11-05.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
# 2019-11-05

Meeting run by shepmaster. Minutes written by pietroalbini.
Attending: aidanhs, alexcrichton, kennytm, Mark-Simulacrum, pietroalbini, shepmaster
Attending: aidanhs, alexcrichton, kennytm, Mark-Simulacrum, pietroalbini,
shepmaster
[Start of the conversation](https://discordapp.com/channels/442252698964721669/443148319431065610/641335927721033732)

## Removing MSYS2 ca-certificates workaround (P-high issue)
Expand Down
45 changes: 25 additions & 20 deletions meetings/2023-10-31.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,49 +3,54 @@
## [In Progress](https://github.com/orgs/rust-lang/projects/24/views/1)

- Set up Mastodon instance ([infra-team#75](https://github.com/rust-lang/infra-team/issues/75))
- Server has been set up and `@rust` account has been created
- Next action: Check with Mara if privileges of `@rust` account can be lowered again
- Next action: Investigate if we can still configure the WebFinger to support `@[email protected]` usernames

- Server has been set up and `@rust` account has been created
- Next action: Check with Mara if privileges of `@rust` account can be lowered
again
- Next action: Investigate if we can still configure the WebFinger to support
`@[email protected]` usernames

- Migrate Monitoring to Datadog ([infra-team#73](https://github.com/rust-lang/infra-team/issues/73))
- Working on proof-of-concept to test logging platform with crates.io team
- Goal is to deprecate Papertrail, where we're hitting the daily log volume limit again
- Next action: Onboard crates.io and on-call teams

- Working on proof-of-concept to test logging platform with crates.io team
- Goal is to deprecate Papertrail, where we're hitting the daily log volume
limit again
- Next action: Onboard crates.io and on-call teams

- Create infrastructure for rust-lang/bors ([infra-team#77](https://github.com/rust-lang/infra-team/issues/77))

- Migrate docs.rs to RDS and ECS ([simpleinfra#353](https://github.com/rust-lang/simpleinfra/issues/353))
- No recent progress
- Next action: Take over open pull request to build images with Packer
- No recent progress
- Next action: Take over open pull request to build images with Packer

## [Backlog](https://github.com/orgs/rust-lang/projects/24/views/1)

- [Update AWS policies for Billing, Cost Management, and Account consoles](https://github.com/rust-lang/simpleinfra/issues/359)
- Deadline until 2023-12-11
- Deadline until 2023-12-11

## Zulip

- [x] [perf is not healthy](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/perf.20is.20not.20healthy)
- [nightly 2023-10-22 missing](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/nightly.202023-10-22.20missing)
- [x] @jdno will create a tracking issue on GitHub
- [x] @jdno will create a tracking issue on GitHub
- [cirrus ci for rustc_codegen_cranelift](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/cirrus.20ci.20for.20rustc_codegen_cranelift)
- [x] @jdno will follow up on the topic
- [x] @jdno will follow up on the topic
- [can't suppress merge commit warning](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/can't.20suppress.20merge.20commit.20warning)
- Will probably require a code change
- Will probably require a code change
- [call with github](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/call.20with.20github)
- [Add perms for `rust-lang/rust` for T-lang-ops](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/Add.20perms.20for.20.60rust-lang.2Frust.60.20for.20T-lang-ops)
- [x] Grant team permissions manually
- [x] Created a [tracking issue](https://github.com/rust-lang/simpleinfra/issues/363)
- [x] Grant team permissions manually
- [x] Created a [tracking issue](https://github.com/rust-lang/simpleinfra/issues/363)
- [x] [doc.crates.io CNAME missing](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/doc.2Ecrates.2Eio.20CNAME.20missing)
- CNAME has been added now that we control the domain on GitHub again
- CNAME has been added now that we control the domain on GitHub again
- [New pull request assignment proposal](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/New.20pull.20request.20assignment.20proposal)
- Introduces new authentication logic, which needs to be reviewed
- [x] @jdno and Jakub will review the pull request
- Introduces new authentication logic, which needs to be reviewed
- [x] @jdno and Jakub will review the pull request
- [Putting Fuchsia in crater](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/Putting.20Fuchsia.20in.20crater)
- Discussion, no action needed right now
- Discussion, no action needed right now
- [x] [crater priority policy](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/crater.20priority.20policy)
- [bors can't pull image, HTTP 429](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/bors.20can't.20pull.20image.2C.20HTTP.20429)
- [Docs redirect minor version to latest patch](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/Docs.20redirect.20minor.20versions.20to.20latest.20patch)
- No concerns, valid feature request
- [x] Created a [tracking issue](https://github.com/rust-lang/simpleinfra/issues/360)
- No concerns, valid feature request
- [x] Created a [tracking issue](https://github.com/rust-lang/simpleinfra/issues/360)
- [sluggish S3 upload](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/sluggish.20S3.20upload)
33 changes: 19 additions & 14 deletions meetings/2023-11-13.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,32 +9,37 @@
### [In Progress](https://github.com/orgs/rust-lang/projects/24/views/1)

- Migrate Monitoring to Datadog ([infra-team#73](https://github.com/rust-lang/infra-team/issues/73))
- Next action: Review permissions and roles
- Next action: Onboard crates.io and on-call teams

- Next action: Review permissions and roles
- Next action: Onboard crates.io and on-call teams

- Create infrastructure for rust-lang/bors ([infra-team#77](https://github.com/rust-lang/infra-team/issues/77))

- Migrate docs.rs to RDS and ECS ([simpleinfra#353](https://github.com/rust-lang/simpleinfra/issues/353))
- Next action: Take over open pull request to build images with Packer
- Next action: Take over open pull request to build images with Packer

### [Backlog](https://github.com/orgs/rust-lang/projects/24/views/1)

### Zulip

- [RLA silence](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/RLA.20Silence)
- Waiting for pull request review
- [ ] JD will review the pull request
- Waiting for pull request review
- [ ] JD will review the pull request
- [ZenDesk](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/ZenDesk)
- Request to set up ZenDesk for the council and route `[email protected]` there
- Next actions: Estimate costs, get approval, and then set up a new account
- [ ] JD will estimate costs and get approval from the Rust Foundation
- Request to set up ZenDesk for the council and route `[email protected]`
there
- Next actions: Estimate costs, get approval, and then set up a new account
- [ ] JD will estimate costs and get approval from the Rust Foundation

## Topics

- Do we want to move these notes to [rust-lang/infra-team](https://github.com/rust-lang/infra-team) after the meeting?
- Yes.
- Do we want to move these notes to [rust-lang/infra-team](https://github.com/rust-lang/infra-team)
after the meeting?
- Yes.
- Any topics for the call with GitHub later today?
- Jakub: Any updates on caching Docker layers?
- We will ask, but probably no news.
- We should implement a proper fix anyways, not rely on the hack that is in place right now.
- See [#t-infra > CI caches](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/CI.20caches) on Zulip
- Jakub: Any updates on caching Docker layers?
- We will ask, but probably no news.
- We should implement a proper fix anyways, not rely on the hack that is in
place right now.
- See [#t-infra > CI caches](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/CI.20caches)
on Zulip
62 changes: 34 additions & 28 deletions meetings/2023-11-20.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,22 @@
### Last Meeting

- [RLA silence](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/RLA.20Silence)
- Waiting for @jdno to review the pull request
- Waiting for @jdno to review the pull request
- [ZenDesk](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/ZenDesk)
- Waiting for @jdno to estimate costs and get approval from the Rust Foundation
- Waiting for @jdno to estimate costs and get approval from the Rust
Foundation

### [In Progress](https://github.com/orgs/rust-lang/projects/24/views/1)

- Migrate Monitoring to Datadog ([infra-team#73](https://github.com/rust-lang/infra-team/issues/73))
- Next action: Summarize implementation details for infra-team
- Next action: Onboard crates.io and on-call teams

- Next action: Summarize implementation details for infra-team
- Next action: Onboard crates.io and on-call teams

- Create infrastructure for rust-lang/bors ([infra-team#77](https://github.com/rust-lang/infra-team/issues/77))

- Migrate docs.rs to RDS and ECS ([simpleinfra#353](https://github.com/rust-lang/simpleinfra/issues/353))
- Next action: Take over open pull request to build images with Packer
- Next action: Take over open pull request to build images with Packer

### [Backlog](https://github.com/orgs/rust-lang/projects/24/views/1)

Expand All @@ -27,37 +29,41 @@
### Zulip

- [merge queue for miri-test-libstd?](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/merge.20queue.20for.20miri-test-libstd.3F)
- Waiting for merge queue to be enabled in repository
- [ ] @jdno will provide documentation for branch rules
- [x] @jdno will enable the feature for the miri-test-libstd repo
- Waiting for merge queue to be enabled in repository
- [ ] @jdno will provide documentation for branch rules
- [x] @jdno will enable the feature for the miri-test-libstd repo
- [www.rust-lang.org Pontoon translations](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/www.2Erust-lang.2Eorg.20Pontoon.20translations)
- Logging into Pontoon instance has been broken (since May 2022)
- Internal server error implies issue with outdated authentication library
- Forwarding our fork is not possible due to squashed migrations upstream
- Last suggestion was upgrading to the commit before the squash
- Next action: Attempt multi-step upgrade again, then reconsider our options
- [x] @jdno will create [issue on backlog](https://github.com/rust-lang/infra-team/issues/91)
- Logging into Pontoon instance has been broken (since May 2022)
- Internal server error implies issue with outdated authentication library
- Forwarding our fork is not possible due to squashed migrations upstream
- Last suggestion was upgrading to the commit before the squash
- Next action: Attempt multi-step upgrade again, then reconsider our options
- [x] @jdno will create [issue on backlog](https://github.com/rust-lang/infra-team/issues/91)
- [Email sent to spam](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/Emails.20sent.20to.20spam)
- `all@` email list receives quite a lot of spam since anyone can send messages to it
- Prior discussion to migrate the list to Google Groups, currently blocked
by [SSO for infra](https://github.com/rust-lang/infra-team/issues/64)
- Next action: Discuss and prioritize when planning 2024
- [ ] @jdno will set up a sync meeting
- `all@` email list receives quite a lot of spam since anyone can send
messages to it
- Prior discussion to migrate the list to Google Groups, currently blocked
by [SSO for infra](https://github.com/rust-lang/infra-team/issues/64)
- Next action: Discuss and prioritize when planning 2024
- [ ] @jdno will set up a sync meeting
- [bors can't pull image, HTTP 429](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/bors.20can't.20pull.20image.2C.20HTTP.20429)
- GitHub Actions is hitting a rate limit on Docker Hub for third-party images (e.g. `ubuntu:22.04`)
- Next action: Monitor frequency of issues before making a decision
- GitHub Actions is hitting a rate limit on Docker Hub for third-party images
(e.g. `ubuntu:22.04`)
- Next action: Monitor frequency of issues before making a decision
- [static downloads - bazel](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/static.20downloads.20-.20bazel)
- Getting bazel to use `.xz` downloads by default might help with bandwidth usage
- Getting bazel to use `.xz` downloads by default might help with bandwidth
usage
- [Confused by crater results](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/Confused.20by.20crater.20results)
- Question about the difference between "dependencies" and "root results" in crater reports
- [ ] @simulacrum will respond to question
- Question about the difference between "dependencies" and "root results" in
crater reports
- [ ] @simulacrum will respond to question

## Topics

- [Proposal to merge infra and release teams](https://rust-lang.zulipchat.com/#narrow/stream/392734-council/topic/Rough.20draft.20proposal.20merging.20Infra.20and.20Release.20teams)
- Rescheduled for next time since @rylev was not available
- Rescheduled for next time since @rylev was not available
- [Backoffice for pull request assignments](https://github.com/rust-lang/triagebot/pull/1745#issuecomment-1812676696)
- Waiting for pull request review from infra-team
- [x] @jdno will review pull request this week
- Waiting for pull request review from infra-team
- [x] @jdno will review pull request this week
- [Add CI OIDC access to new bors branches](https://github.com/rust-lang/simpleinfra/pull/355)
- Waiting for pull request review from infra-team and Walter
- Waiting for pull request review from infra-team and Walter
Loading

0 comments on commit f622105

Please sign in to comment.