fix: rendering of merge emoji when upstream was modified #5064
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfheen
requested review from
chenrui333,
nitrocode and
X-Guardian
and removed request for
a team
jamengual
changed the title
|
@tfheen please sign the commits to pass DCO |
|
Just to make sure I understand the request, you mean sign, as in adding a Signed-off-by? I can do that. |
Without this, we would typically get ``` Plan: 3 to add, 0 to change, 0 to destroy.:twisted_rightwards_arrows: Upstream was modified, a new merge was performed. ``` With this, we should be getting whitespace before the `:twisted_rightwards_arrows` part. Signed-off-by: Tollef Fog Heen <[email protected]>
tfheen
force-pushed
the
tfheen/fix-render
branch
from
63bca38 to
3c27b5c
Compare
X-Guardian
changed the title
X-Guardian
approved these changes
Nov 17, 2024
1 task
terakoya76
pushed a commit
to terakoya76/atlantis
that referenced
this pull request
Dec 31, 2024
…#5064) Signed-off-by: Tollef Fog Heen <[email protected]>
kvanzuijlen
pushed a commit
to kvanzuijlen/atlantis
that referenced
this pull request
Jan 4, 2025
…#5064) Signed-off-by: Tollef Fog Heen <[email protected]> Signed-off-by: kvanzuijlen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Without this, we would typically get
With this, we should be getting whitespace before the
:twisted_rightwards_arrowspart.why
Without this, we would not have our beautiful 🔀 rendered as an emoji.