Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong formatting with merge checkout strategy #4767

Closed
pavelpulec opened this issue Jul 19, 2024 · 1 comment
Closed

Wrong formatting with merge checkout strategy #4767

pavelpulec opened this issue Jul 19, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@pavelpulec
Copy link

pavelpulec commented Jul 19, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Overview of the Issue

We've recently enabled the "merge" checkout strategy and we noticed the wrong formatting of messages. See the screenshot below. The emoji is not evaluated and the information about the upstream modifications goes on the same line in a PR comment.

image

Reproduction Steps

It shows up in all PRs that are not up 2 date with the base branch and Atlantis tries to merge them.

Environment details

  • Atlantis version: 0.28.1
  • Deployment method: ECS, TF module -> terraform-aws-modules/ecs/aws//modules/service
  • If not running the latest Atlantis version have you tried to reproduce this issue on the latest version: No. I'm running almost the latest version and there are no recent changes in server/events/templates/merged_again.tmpl.
  • Atlantis flags: ATLANTIS_CHECKOUT_STRATEGY=merge
@pavelpulec pavelpulec added the bug Something isn't working label Jul 19, 2024
@X-Guardian
Copy link
Contributor

Fixed in #5064

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants