Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partner Profile : clean up social media, request types and pick up emails #4829

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Partner Profile : clean up social media, request types and pick up emails #4829

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afea032
clean up social media, request types and pick up emails
cielf Dec 4, 2024
37d32a9
suggested changes
cielf Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 61 additions & 0 deletions db/migrate/20241204111437_cleanup_invalid_partner_profiles.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
class CleanupInvalidPartnerProfiles < ActiveRecord::Migration[7.1]
def up
# ActiveRecord::Base.logger = Logger.new(STDOUT)
invalid_profiles = Partners::Profile.all.reject(&:valid?)
Copy link
Collaborator

@coalest coalest Dec 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other question. Are there many Partners::Profile records in production? If there are many, then loading them all at once like this could cause a memory spike and fire off thousands of database queries.

The safer option when dealing with lots of records would be using something like find_each:

Partners::Profile.find_each(batch_size: SOME_NUMBER) do |profile|
  next if profile.valid?
  # code
  sleep(0.01) # throttle
end

If there aren't many records it doesn't really matter and ignore this comment.

Copy link
Collaborator Author

@cielf cielf Dec 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Define many g. There are about 6000.
I have been testing this against prod data, and it will run during a maintenance window,

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find_each is technically better, but for a one-off migration like this it's usually not worth the fuss.


return if !invalid_profiles.present?

invalid_profiles.each do |profile|
# address invalid social media section

unless (profile.website.present? ||
profile.twitter.present? ||
profile.facebook.present? ||
profile.instagram.present? ||
profile.no_social_media_presence ||
profile.partner.partials_to_show.exclude?("media_information"))
profile.no_social_media_presence = true
end

# address no request types set

unless(profile.enable_quantity_based_requests || profile.enable_individual_requests || profile.enable_child_based_requests)
profile.enable_quantity_based_requests = profile.partner.organization.enable_quantity_based_requests
profile.enable_individual_requests = profile.partner.organization.enable_individual_requests
profile.enable_child_based_requests = profile.partner.organization.enable_child_based_requests
end



# address bad pickup email

unless profile.valid?
# if profile is not valid at this point, it is a bad pickup email

pick_up = profile.pick_up_email
pick_up.downcase!
pick_up.strip!
if pick_up == "none" or pick_up == "na" or pick_up == "n/a" or pick_up == "see above"
profile.pick_up_email = ""
else
profile.pick_up_email.gsub!("/",",")
profile.pick_up_email.gsub!(";",",")
profile.pick_up_email.gsub!(" or ", ", ")
profile.pick_up_email.gsub!(" and ", ", ")
profile.pick_up_email.gsub!(" & ", ", ")
end

if(!profile.valid?) ## If we can't fix the email, append it to the name so we don't lose the information aspect
profile.pick_up_name += ", email: " + profile.pick_up_email
profile.pick_up_email = ""
end
end

profile.save!

end
end
def down
# irreversible
end
end
Loading