Partner Profile : clean up social media, request types and pick up emails #4829
Conversation
| if pick_up == "none" or pick_up == "na" or pick_up == "n/a" or pick_up == "see above" | ||
| profile.pick_up_email = "" | ||
| else | ||
| profile.pick_up_email.sub!("/",",") |
There was a problem hiding this comment.
Do any of the pick_up_emails have multiple forward slashes or semicolons? If so, sub! would only remove the first one. Is that intended or would gsub! be safer here?
There was a problem hiding this comment.
it would. will fix tomorrow
| # ActiveRecord::Base.logger = Logger.new(STDOUT) | ||
| invalid_profiles = Partners::Profile.all.reject(&:valid?) | ||
|
|
||
| return if !invalid_profiles |
There was a problem hiding this comment.
nit: Since invalid_profiles will always be an array, it will always be truthy so this guard statement isn't doing much atm. Maybe Rails helpers like .present? or .blank? would be useful here?
Not a big deal though because if invalid_profiles is an empty array the block below won't execute.
| class CleanupInvalidPartnerProfiles < ActiveRecord::Migration[7.1] | ||
| def up | ||
| # ActiveRecord::Base.logger = Logger.new(STDOUT) | ||
| invalid_profiles = Partners::Profile.all.reject(&:valid?) |
There was a problem hiding this comment.
One other question. Are there many Partners::Profile records in production? If there are many, then loading them all at once like this could cause a memory spike and fire off thousands of database queries.
The safer option when dealing with lots of records would be using something like find_each:
Partners::Profile.find_each(batch_size: SOME_NUMBER) do |profile|
next if profile.valid?
# code
sleep(0.01) # throttle
endIf there aren't many records it doesn't really matter and ignore this comment.
There was a problem hiding this comment.
Define many g. There are about 6000.
I have been testing this against prod data, and it will run during a maintenance window,
There was a problem hiding this comment.
find_each is technically better, but for a one-off migration like this it's usually not worth the fuss.
Required before #4801
Description
This cleans up the partner profiles so they will be valid
Ran against production data with puts in place to check reasonablilty of that last step
Include anything else we should know about. -->
Type of change
How Has This Been Tested?
Ran against production copy.